-
-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(readme): added types #660
Changes from 5 commits
2059c80
e4d02ac
337e73a
bc5da1a
110ffe1
e74a3d9
6bd3ae4
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -249,7 +249,7 @@ type TransformerObject = { | |
cache?: boolean | TransformerCacheObject | undefined; | ||
}; | ||
type Transform = TransformerFunction | TransformerObject; | ||
type Filter = (filepath: string) => any; | ||
type Filter = (filepath: string) => boolean; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should add this here https://github.com/webpack-contrib/copy-webpack-plugin/blob/master/src/index.js#L95 and run There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done |
||
type TransformAllFunction = ( | ||
data: { | ||
data: Buffer; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should not be
any
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
copy-webpack-plugin/types/index.d.ts
Line 70 in 9b5a314
🤔 Am I looking at the wrong type then 😕
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add
@returns
to types here too, looks like bug on our sideThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
copy-webpack-plugin/types/index.d.ts
Lines 253 to 259 in 9b5a314
I thought this returned any