-
-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: do not duplicate css on composes
#1040
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1040 +/- ##
==========================================
+ Coverage 96.84% 98.14% +1.29%
==========================================
Files 10 10
Lines 476 484 +8
Branches 147 150 +3
==========================================
+ Hits 461 475 +14
+ Misses 12 8 -4
+ Partials 3 1 -2
Continue to review full report at Codecov.
|
6a3f57f
to
48246b5
Compare
48246b5
to
777d876
Compare
thanks for all the hard work @evilebottnawi ! |
@jquense I will ping you when I done release, check if everything is well fixed |
@@ -22,15 +22,33 @@ module.exports = function(useSourceMap) { | |||
|
|||
// import a list of modules into the list | |||
// eslint-disable-next-line func-names | |||
list.i = function(modules, mediaQuery) { | |||
list.i = function(modules, mediaQuery, dedupe) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that possible to have it to be true
by default?
e.g.
function(modules, mediaQuery, dedupe = true)
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why?
This PR contains a:
Motivation / Use-Case
fixes #1037
Breaking Changes
No
Additional Info
No