Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: invert Function behavior for url and import options #939

Merged
merged 1 commit into from
May 28, 2019

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

fixes #891

Breaking Changes

Yes

BREAKING CHANGE: you should return true when you want handle url/@import and return false if not

Additional Info

No

BREAKING CHANGE: you should return `true` when you want handle `url`/`@import` and return `false` if not
@codecov
Copy link

codecov bot commented May 28, 2019

Codecov Report

Merging #939 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #939   +/-   ##
=======================================
  Coverage   99.27%   99.27%           
=======================================
  Files          10       10           
  Lines         412      412           
  Branches      122      122           
=======================================
  Hits          409      409           
  Misses          3        3
Impacted Files Coverage Δ
src/utils.js 99.23% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 888cca0...e7b1fb2. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix url filter behavior
1 participant