-
-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support @value
at-rule in selectors
#941
feat: support @value
at-rule in selectors
#941
Conversation
BREAKING CHANGE: if you have name of `@value` in selector it will be replaced, you need to rename your name of `@value` or rename your selector
Codecov Report
@@ Coverage Diff @@
## master #941 +/- ##
==========================================
+ Coverage 99.27% 99.27% +<.01%
==========================================
Files 10 10
Lines 412 414 +2
Branches 122 124 +2
==========================================
+ Hits 409 411 +2
Misses 3 3
Continue to review full report at Codecov.
|
Is there any way to opt out of this feature? I use the following pattern a lot, so now I need a large refactoring to make it work again:
|
@Hypnosphi no, just rename your variable to
It is breaking change for |
In
Renaming it would mean that in |
@Hypnosphi just use other class or change variable name, it can't be opt, sorry |
@evilebottnawi Would you accept a PR making it possible to opt-out? In our project, we'd have to update about 5000 lines because of the feature. |
@princed it can't be option, postcss plugins were rewritten
therefore we do major release, just don't update if you don't have time on this right now |
This PR contains a:
Motivation / Use-Case
Support
@value
at rule in selectorsBreaking Changes
Yes
BREAKING CHANGE: if you have name of
@value
in selector it will be replaced, you need to rename your name of@value
or rename your selectorAdditional Info
No
For next major release we need:
nothing
in test of css-loader@value test: 'something'
in selector