Port babel loader fs cache as the default caching engine #159

viankakrisna · 2017-02-27T19:24:32Z

This pr implements the tried and tested fs-cache from babel-loader. It still need to test some case though. The current implementation of caching is quite buggy based on the issue on facebook/create-react-app#1656 .

Todos:

Create an updated tests that watches *.gz files which generated by loader-fs-cache instead of data.json and other use cases..
~~Create benchmark and see the speed we gain by turning on cache~~ Will do it another time
Pass the tests

For people who want to test this pr I've published an npm package in https://www.npmjs.com/package/eslint-loader-fs-cache

gaearon · 2017-02-27T19:39:30Z

Needs rebasing?

viankakrisna · 2017-02-27T20:22:00Z

@gaearon done!

MoOx · 2017-02-27T21:04:59Z

Can't we try to use a common module instead of copy/pasting/adapting?

gaearon · 2017-02-27T21:30:07Z

It would be nice but as a follow up work IMO :-) We're hoping to fix this asap, and extracting a module would require coordination between both packages and somebody willing to do the work.

gaearon · 2017-02-27T21:32:03Z

🤔

viankakrisna · 2017-02-27T21:32:52Z

ah, should i coordinate first? @gaearon

gaearon · 2017-02-27T22:10:48Z

If you already published it, I guess it's fine! Can you send a PR to babel-loader later too?
Is this an exact copy?

viankakrisna · 2017-02-28T04:46:57Z

@gaearon gladly! yes, essentially i just wrap the babel implementation with a function that takes the name for findCacheDir https://github.com/viankakrisna/loader-fs-cache/blob/master/index.js#L179

viankakrisna · 2017-02-28T13:23:04Z

@gaearon @MoOx currently i'm stuck with writing an updated test for cache in this pr

gaearon · 2017-02-28T14:26:34Z

This is reported to work well.

viankakrisna · 2017-03-03T10:36:47Z

@MoOx @gaearon do you guys have time to review the code? I've been stuck why the tests are failing in quiet mode

gaearon · 2017-03-03T13:38:29Z

Unfortunately I don't know anything about the test setup in this repo, @MoOx can you help?

peternewnham · 2017-03-03T23:40:52Z

@viankakrisna if you're having trouble with the tests hanging it's because you have a bunch of test.cb() calls in the cache.js file which are never being ended so they are just waiting forever - https://github.com/avajs/ava#tend

viankakrisna · 2017-03-05T19:26:05Z

@wrakky ah, haven't pushed the updated codes! 😢 I'm trying to figure out why all the tests would fail, even when the cache option is turned off 😭

peternewnham · 2017-03-05T23:24:00Z

index.js

  }
+  printLinterOutput(lint(engine, input, resourcePath), config, this)
+  this.callback(input, map)


@viankakrisna i think this is your problem - first argument to this.callback is an error so should be set to null like the other callback a couple of line above it.

viankakrisna · 2017-03-06T05:58:45Z

@wrakky thank you! That works! I wonder why it's changed like that though 😅
I'll update the tests for caching tonight, so I can remove the [WIP] tag.

viankakrisna · 2017-03-06T20:25:13Z

@MoOx I think it should be good now 👍

MoOx · 2017-03-07T14:59:08Z

It seems to be good for me, just one last question: I think by reading the tests that you are covering by tests things that should be taken care by the module that handle the cache (loader-fs-cache).
Am I correct? I think some tests are not really necessary in this repo and make more sense in loader-fs-cache). Tell me if I am wrong (which happen often in my life ^^).
We can merge this PR and move the tests after if you want this asap :)

viankakrisna · 2017-03-07T15:17:29Z

@MoOx yeah, that's what I'm thinking too, do you have any particular line of the test that should be moved to loader-fs-cache? And how can we test the cache feature without leaking the implementation detail?

viankakrisna · 2017-03-07T15:27:19Z

@MoOx I think right now it's not too much in a rush, because we've already reverted the changes to just not use the cache setting. But if we can ship this, we can surface the bugs early in CRA environment. I'm curious what @gaearon thinks about it though.

MoOx · 2017-03-23T06:09:42Z

test/cache.js

+  })
+})
+
+test.cb.serial("should output json.gz files to standard cache dir by default", 


this is the kind of test that should live in the loader cache module.

MoOx · 2017-03-23T06:10:08Z

Sorry my time is limited atm. Let's ship this as it is.

MoOx · 2017-03-23T06:39:43Z

Published as 1.7.0

kerrmarin · 2017-03-23T15:58:44Z

Hi, this latest PR looks like it broke dependencies on mkdirp as per #166. Can we revert this and publish 1.7.1?

MoOx · 2017-03-23T18:31:54Z

@kerrmarin #166 (comment)

viankakrisna changed the title ~~port babel loader fs cache as the default caching engine~~ [WIP] port babel loader fs cache as the default caching engine Feb 27, 2017

viankakrisna mentioned this pull request Feb 27, 2017

React App Compilation failing due to missing eslint cache file facebook/create-react-app#1656

Closed

gaearon mentioned this pull request Feb 27, 2017

Revert "Enable eslint caching in development" facebook/create-react-app#1665

Merged

viankakrisna force-pushed the port_babel_loader_fs_cache branch 2 times, most recently from 3695876 to fdbca0e Compare February 27, 2017 20:20

MoOx mentioned this pull request Feb 28, 2017

add checks before writing and reading cache #158

Closed

viankakrisna force-pushed the port_babel_loader_fs_cache branch from 9dcef3c to 847f5e0 Compare February 28, 2017 15:54

use loader-fs-cache as the caching engine

e33ea6b

viankakrisna force-pushed the port_babel_loader_fs_cache branch from 847f5e0 to e33ea6b Compare February 28, 2017 16:43

add template for tests

d6d8e1d

gaearon mentioned this pull request Feb 28, 2017

Consider using eslint-loader cache option facebook/create-react-app#740

Closed

peternewnham reviewed Mar 5, 2017

View reviewed changes

pass null as the first argument to this.callback()

f0644a9

add tests and fix cache setting

792f725

viankakrisna changed the title ~~[WIP] port babel loader fs cache as the default caching engine~~ Port babel loader fs cache as the default caching engine Mar 6, 2017

MoOx reviewed Mar 23, 2017

View reviewed changes

MoOx merged commit 7367f41 into webpack-contrib:master Mar 23, 2017

MoOx mentioned this pull request Mar 23, 2017

Bugfix #164

Closed

genintho mentioned this pull request Apr 4, 2017

Remove unused dependency find-cache-dir #170

Merged

renovate bot mentioned this pull request Feb 2, 2018

chore(deps): update dependency eslint-loader to v1.9.0 - autoclosed Pragmateam/coding-dojo#91

Closed

aaharu mentioned this pull request Apr 10, 2020

refactor: new cache implementation #320

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Port babel loader fs cache as the default caching engine #159

Port babel loader fs cache as the default caching engine #159

viankakrisna commented Feb 27, 2017 •

edited

Loading

gaearon commented Feb 27, 2017

viankakrisna commented Feb 27, 2017

MoOx commented Feb 27, 2017

gaearon commented Feb 27, 2017

gaearon commented Feb 27, 2017

viankakrisna commented Feb 27, 2017

gaearon commented Feb 27, 2017

viankakrisna commented Feb 28, 2017

viankakrisna commented Feb 28, 2017

gaearon commented Feb 28, 2017

viankakrisna commented Mar 3, 2017 •

edited

Loading

gaearon commented Mar 3, 2017

peternewnham commented Mar 3, 2017

viankakrisna commented Mar 5, 2017

peternewnham Mar 5, 2017

viankakrisna commented Mar 6, 2017 •

edited

Loading

viankakrisna commented Mar 6, 2017

MoOx commented Mar 7, 2017

viankakrisna commented Mar 7, 2017

viankakrisna commented Mar 7, 2017

MoOx Mar 23, 2017

MoOx commented Mar 23, 2017

MoOx commented Mar 23, 2017

kerrmarin commented Mar 23, 2017

MoOx commented Mar 23, 2017

Port babel loader fs cache as the default caching engine #159

Port babel loader fs cache as the default caching engine #159

Conversation

viankakrisna commented Feb 27, 2017 • edited Loading

gaearon commented Feb 27, 2017

viankakrisna commented Feb 27, 2017

MoOx commented Feb 27, 2017

gaearon commented Feb 27, 2017

gaearon commented Feb 27, 2017

viankakrisna commented Feb 27, 2017

gaearon commented Feb 27, 2017

viankakrisna commented Feb 28, 2017

viankakrisna commented Feb 28, 2017

gaearon commented Feb 28, 2017

viankakrisna commented Mar 3, 2017 • edited Loading

gaearon commented Mar 3, 2017

peternewnham commented Mar 3, 2017

viankakrisna commented Mar 5, 2017

peternewnham Mar 5, 2017

Choose a reason for hiding this comment

viankakrisna commented Mar 6, 2017 • edited Loading

viankakrisna commented Mar 6, 2017

MoOx commented Mar 7, 2017

viankakrisna commented Mar 7, 2017

viankakrisna commented Mar 7, 2017

MoOx Mar 23, 2017

Choose a reason for hiding this comment

MoOx commented Mar 23, 2017

MoOx commented Mar 23, 2017

kerrmarin commented Mar 23, 2017

MoOx commented Mar 23, 2017

viankakrisna commented Feb 27, 2017 •

edited

Loading

viankakrisna commented Mar 3, 2017 •

edited

Loading

viankakrisna commented Mar 6, 2017 •

edited

Loading