Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WDS significant increase in recompile time after migrating from eslint-loader #20

Closed
tpettrov opened this issue Oct 8, 2020 · 8 comments

Comments

@tpettrov
Copy link

tpettrov commented Oct 8, 2020

After migrating from eslint-loader and updating eslint to v7 WDS recompile time increased abnormal.

  • Operating System: Windows 10
  • Node Version: v12.13.1
  • NPM Version: 6.12.1
  • webpack Version: 4.42.0
  • eslint-webpack-plugin Version: 2.1.0
  • webpack-dev-server: 3.1.14
  • eslint : v.7.0.0

Expected Behavior

Recompile time stays normal.

Actual Behavior

Recompile time increased significantly from 1-3 seconds to around 10.

@alexander-akait
Copy link
Member

Feel free to send a fix, I think we need clean something

@ricardogobbosouza
Copy link
Collaborator

ricardogobbosouza commented Oct 8, 2020

Hi @tpettrov
Did you try to enable option lintDirtyModulesOnly?

@tpettrov
Copy link
Author

tpettrov commented Oct 9, 2020

Hi @ricardogobbosouza
Just checked it and yes recompile time is probably even faster. Many thanks.

@elisherer
Copy link

I also tried turning lintDirtyModulesOnly on but it failed detecting a change I made like creating an unused variable.

@CarlosAzocar
Copy link

Same, turning lintDirtyModulesOnly on but it failed detecting changes

@vegerot
Copy link

vegerot commented Nov 3, 2020

@ricardogobbosouza lintDirtyModulesOnly is a nice idea, but I would rather just have the linting be done asynchronously, as is done with the TypeScript checker (and as I describe in #33 (comment))

@ricardogobbosouza
Copy link
Collaborator

Hi @vegerot, @CarlosAzocar, @elisherer
Try v2.2.0

@vegerot
Copy link

vegerot commented Nov 4, 2020

@ricardogobbosouza thanks! Looks like the overhead should be must smaller now. As someone that's a little bit anal about compile times, I do still wish this could be done async (like TypeScript). But this should make it much more bearable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants