fix: wrong regex in middleware url pattern #295
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This causes files emitted to publicPath not in a subdirectory to fail to load.
|
|
dtinth
added a commit
to bemusic/bemuse
that referenced
this pull request
Dec 24, 2017
…a subdirectory
|
(Should be) fixed by #293. Please reopen if it shouldn't. Thx :) |
|
Released in |
rajr5
pushed a commit
to rajr5/bemuse
that referenced
this pull request
Jun 23, 2023
…a subdirectory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I upgraded
karma-webpackto the latest version. It seems that assets emitted directly to the webpack’soutput.pathdirectory (not in a subdirectory) couldn’t be found.Debugging this issue reveals that the regex used to tell karma to delegate to webpack-dev-server is incorrect. It has an extra
/at the end. I assume that the author intended to say$instead, since there is already a/in front, (otherwise, there is no point in having.*).Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
http://localhost:9876/tmp/_karma_webpack_/24476c7dae9a65fd37e5.worker.js returns 404.
What is the new behavior?
http://localhost:9876/tmp/_karma_webpack_/24476c7dae9a65fd37e5.worker.js now returns the emitted file as intended.
Does this PR introduce a breaking change?
Other information:
Workaround: Just make sure you setup loaders (e.g. file-loader, worker-loader) to emit files inside a directory instead.