Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fileLoader prevents less's @import from sharing variable/mixin context with imported less files #21

Closed
mattly opened this issue Oct 30, 2014 · 3 comments

Comments

@mattly
Copy link

mattly commented Oct 30, 2014

for example:

@import "variables.less"; // declares variables
@import "mixins.less"; // declares mixins
@import "some_styles.less"; // declares styles, relies on variables / mixins

because the file loader is effectively compiling each sub-import individually, the context is not being shared. If I just delete the fileLoader method from the code and use the built-in one, it works as expected.

This is a problem because many third-party tools, libraries and themes rely on this mechanism and using them with webpack shouldn't require adapting them to the loader's peculiarities.

@jhnns
Copy link
Member

jhnns commented Oct 31, 2014

Mhmm I don't know if that's a version issue but I'm pretty sure that sharing context works in my project.

@mattly
Copy link
Author

mattly commented Oct 31, 2014

I'll see if I can produce a failing test case, but for us it was basically, bootstrap.less

Sent from my iPhone

On Oct 31, 2014, at 04:45, Johannes Ewald notifications@github.com wrote:

Mhmm I don't know if that's a version issue but I'm pretty sure that sharing context works in my project.


Reply to this email directly or view it on GitHub.

@jhnns
Copy link
Member

jhnns commented Mar 17, 2017

Closing this one due inactivity.

With #169 it will also be possible to disable webpack's resolver entirely.

@jhnns jhnns closed this as completed Mar 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants