From 82ed6633e907ef4f7e598f25334fed06aa2e4565 Mon Sep 17 00:00:00 2001 From: Alexander Akait <4567934+alexander-akait@users.noreply.github.com> Date: Tue, 29 Nov 2022 20:42:52 +0300 Subject: [PATCH] refactor: fix compatibility with old browsers (#1000) --- src/index.js | 4 +++- ...{0.32c982869d9446e21cfa.css => 0.945622d4f51f3fe3a0d0.css} | 0 .../{32c982869d9446e21cfa.css => 945622d4f51f3fe3a0d0.css} | 0 .../expected/webpack-5-importModule/main.js | 4 ++-- ...{0.70641d5edcf4cb37424c.css => 0.de494c1e7411c41d8362.css} | 0 .../{70641d5edcf4cb37424c.css => de494c1e7411c41d8362.css} | 0 test/cases/chunkFilename-fullhash/expected/webpack-5/main.js | 4 ++-- test/cases/hmr/expected/main.js | 2 +- test/cases/insert-undefined/expected/main.js | 2 +- 9 files changed, 9 insertions(+), 7 deletions(-) rename test/cases/chunkFilename-fullhash/expected/webpack-5-importModule/{0.32c982869d9446e21cfa.css => 0.945622d4f51f3fe3a0d0.css} (100%) rename test/cases/chunkFilename-fullhash/expected/webpack-5-importModule/{32c982869d9446e21cfa.css => 945622d4f51f3fe3a0d0.css} (100%) rename test/cases/chunkFilename-fullhash/expected/webpack-5/{0.70641d5edcf4cb37424c.css => 0.de494c1e7411c41d8362.css} (100%) rename test/cases/chunkFilename-fullhash/expected/webpack-5/{70641d5edcf4cb37424c.css => de494c1e7411c41d8362.css} (100%) diff --git a/src/index.js b/src/index.js index cc1a4a90..6f76879e 100644 --- a/src/index.js +++ b/src/index.js @@ -888,7 +888,9 @@ class MiniCssExtractPlugin { ]) : Template.asString([ "if (oldTag) {", - Template.indent(["oldTag.after(linkTag);"]), + Template.indent([ + "oldTag.parentNode.insertBefore(linkTag, oldTag.nextSibling);", + ]), "} else {", Template.indent(["document.head.appendChild(linkTag);"]), "}", diff --git a/test/cases/chunkFilename-fullhash/expected/webpack-5-importModule/0.32c982869d9446e21cfa.css b/test/cases/chunkFilename-fullhash/expected/webpack-5-importModule/0.945622d4f51f3fe3a0d0.css similarity index 100% rename from test/cases/chunkFilename-fullhash/expected/webpack-5-importModule/0.32c982869d9446e21cfa.css rename to test/cases/chunkFilename-fullhash/expected/webpack-5-importModule/0.945622d4f51f3fe3a0d0.css diff --git a/test/cases/chunkFilename-fullhash/expected/webpack-5-importModule/32c982869d9446e21cfa.css b/test/cases/chunkFilename-fullhash/expected/webpack-5-importModule/945622d4f51f3fe3a0d0.css similarity index 100% rename from test/cases/chunkFilename-fullhash/expected/webpack-5-importModule/32c982869d9446e21cfa.css rename to test/cases/chunkFilename-fullhash/expected/webpack-5-importModule/945622d4f51f3fe3a0d0.css diff --git a/test/cases/chunkFilename-fullhash/expected/webpack-5-importModule/main.js b/test/cases/chunkFilename-fullhash/expected/webpack-5-importModule/main.js index 6acd31cc..8c4d255c 100644 --- a/test/cases/chunkFilename-fullhash/expected/webpack-5-importModule/main.js +++ b/test/cases/chunkFilename-fullhash/expected/webpack-5-importModule/main.js @@ -73,7 +73,7 @@ __webpack_require__.r(__webpack_exports__); /******/ /******/ /* webpack/runtime/getFullHash */ /******/ (() => { -/******/ __webpack_require__.h = () => ("32c982869d9446e21cfa") +/******/ __webpack_require__.h = () => ("945622d4f51f3fe3a0d0") /******/ })(); /******/ /******/ /* webpack/runtime/global */ @@ -196,7 +196,7 @@ __webpack_require__.r(__webpack_exports__); /******/ linkTag.href = fullhref; /******/ /******/ if (oldTag) { -/******/ oldTag.after(linkTag); +/******/ oldTag.parentNode.insertBefore(linkTag, oldTag.nextSibling); /******/ } else { /******/ document.head.appendChild(linkTag); /******/ } diff --git a/test/cases/chunkFilename-fullhash/expected/webpack-5/0.70641d5edcf4cb37424c.css b/test/cases/chunkFilename-fullhash/expected/webpack-5/0.de494c1e7411c41d8362.css similarity index 100% rename from test/cases/chunkFilename-fullhash/expected/webpack-5/0.70641d5edcf4cb37424c.css rename to test/cases/chunkFilename-fullhash/expected/webpack-5/0.de494c1e7411c41d8362.css diff --git a/test/cases/chunkFilename-fullhash/expected/webpack-5/70641d5edcf4cb37424c.css b/test/cases/chunkFilename-fullhash/expected/webpack-5/de494c1e7411c41d8362.css similarity index 100% rename from test/cases/chunkFilename-fullhash/expected/webpack-5/70641d5edcf4cb37424c.css rename to test/cases/chunkFilename-fullhash/expected/webpack-5/de494c1e7411c41d8362.css diff --git a/test/cases/chunkFilename-fullhash/expected/webpack-5/main.js b/test/cases/chunkFilename-fullhash/expected/webpack-5/main.js index 58994c6c..9cbf1619 100644 --- a/test/cases/chunkFilename-fullhash/expected/webpack-5/main.js +++ b/test/cases/chunkFilename-fullhash/expected/webpack-5/main.js @@ -73,7 +73,7 @@ __webpack_require__.r(__webpack_exports__); /******/ /******/ /* webpack/runtime/getFullHash */ /******/ (() => { -/******/ __webpack_require__.h = () => ("70641d5edcf4cb37424c") +/******/ __webpack_require__.h = () => ("de494c1e7411c41d8362") /******/ })(); /******/ /******/ /* webpack/runtime/global */ @@ -196,7 +196,7 @@ __webpack_require__.r(__webpack_exports__); /******/ linkTag.href = fullhref; /******/ /******/ if (oldTag) { -/******/ oldTag.after(linkTag); +/******/ oldTag.parentNode.insertBefore(linkTag, oldTag.nextSibling); /******/ } else { /******/ document.head.appendChild(linkTag); /******/ } diff --git a/test/cases/hmr/expected/main.js b/test/cases/hmr/expected/main.js index ee4a6f9f..eebf4011 100644 --- a/test/cases/hmr/expected/main.js +++ b/test/cases/hmr/expected/main.js @@ -959,7 +959,7 @@ __webpack_require__.r(__webpack_exports__); /******/ linkTag.href = fullhref; /******/ /******/ if (oldTag) { -/******/ oldTag.after(linkTag); +/******/ oldTag.parentNode.insertBefore(linkTag, oldTag.nextSibling); /******/ } else { /******/ document.head.appendChild(linkTag); /******/ } diff --git a/test/cases/insert-undefined/expected/main.js b/test/cases/insert-undefined/expected/main.js index 06940274..907e94ad 100644 --- a/test/cases/insert-undefined/expected/main.js +++ b/test/cases/insert-undefined/expected/main.js @@ -180,7 +180,7 @@ /******/ linkTag.href = fullhref; /******/ /******/ if (oldTag) { -/******/ oldTag.after(linkTag); +/******/ oldTag.parentNode.insertBefore(linkTag, oldTag.nextSibling); /******/ } else { /******/ document.head.appendChild(linkTag); /******/ }