Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ';'to module.media #1051

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Conversation

Fi2zz
Copy link
Contributor

@Fi2zz Fi2zz commented Sep 11, 2023

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Use-Case

Giving css with at-rule-import

@import "https://cdn.jsdelivr.net/npm/bootstrap@5.3.1/dist/css/bootstrap.min.css" screen and (min-width:640px);
@import "https://cdn.jsdelivr.net/npm/bootstrap@5.3.1/dist/css/bootstrap.min.css"; 

div{
  color:red;
  font-size:14px
}

Before bugfix

@import "https://cdn.jsdelivr.net/npm/bootstrap@5.3.1/dist/css/bootstrap.min.css" screen and (min-width:640px)@import "https://cdn.jsdelivr.net/npm/bootstrap@5.3.1/dist/css/bootstrap.min.css"; 

div{
  color:red;
  font-size:14px
}

After bugfix

@import "https://cdn.jsdelivr.net/npm/bootstrap@5.3.1/dist/css/bootstrap.min.css" screen and (min-width:640px);
@import "https://cdn.jsdelivr.net/npm/bootstrap@5.3.1/dist/css/bootstrap.min.css"; 

div{
  color:red;
  font-size:14px
}

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 11, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: Fi2zz / name: Fitzz (5c365d3)

@Fi2zz Fi2zz marked this pull request as draft September 11, 2023 07:09
@Fi2zz Fi2zz marked this pull request as ready for review September 11, 2023 07:10
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, can we add a test case?

@Fi2zz
Copy link
Contributor Author

Fi2zz commented Dec 21, 2023

Looks good, can we add a test case?

please check here
@alexander-akait

Copy link

codecov bot commented Dec 22, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (d5e540b) 90.54% compared to head (5c365d3) 89.96%.
Report is 2 commits behind head on master.

Files Patch % Lines
src/index.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1051      +/-   ##
==========================================
- Coverage   90.54%   89.96%   -0.59%     
==========================================
  Files           5        5              
  Lines         857      857              
  Branches      243      243              
==========================================
- Hits          776      771       -5     
- Misses         71       75       +4     
- Partials       10       11       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants