Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(loader): fix publicPath regression #384

Merged
merged 5 commits into from
May 14, 2019
Merged

fix(loader): fix publicPath regression #384

merged 5 commits into from
May 14, 2019

Conversation

rmja
Copy link
Contributor

@rmja rmja commented Apr 25, 2019

... when the publicPath is set to an empty string. The publicPath should resolve to an empty string in this case and not /.

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

A regression caused by #373 makes it impossible to set publicPath to an empty string. This fix brings this feature back.

Breaking Changes

Additional Info

... when the publicPath is set to an empty string. The publicPath should resolve to an empty string in this case and _not_ `/`
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please add tests

@rmja rmja mentioned this pull request Apr 26, 2019
6 tasks
@alexander-akait
Copy link
Member

Ignore CI problem , just add tests and we can release new version

@jsf-clabot
Copy link

jsf-clabot commented Apr 26, 2019

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, let's wait CI green

@alexander-akait
Copy link
Member

Also please change email on commit and do force push, need accept CLA, thanks

@rmja
Copy link
Contributor Author

rmja commented Apr 26, 2019

@evilebottnawi year, sorry about that. I think it is fixed now.

@codecov
Copy link

codecov bot commented May 13, 2019

Codecov Report

Merging #384 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #384   +/-   ##
=======================================
  Coverage   65.19%   65.19%           
=======================================
  Files           4        4           
  Lines         408      408           
  Branches       84       84           
=======================================
  Hits          266      266           
  Misses        118      118           
  Partials       24       24
Impacted Files Coverage Δ
src/loader.js 89.41% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3a6dba...c996d15. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants