better support for webpack 5 #595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update manual test cases update CssModule for webpack 5 (to avoid deprecation) clean up inconsistency in loader
using filenameTemplate is incorrect It would point to a .js filename.
remove hmr option for webpack 5 (now automatically) fix/update test cases
sokra
force-pushed
the
bugfix/webpack-5
branch
from
256ad29
to
eb18378
Compare
Codecov Report
@@ Coverage Diff @@
## master #595 +/- ##
==========================================
- Coverage 91.16% 87.95% -3.21%
==========================================
Files 9 10 +1
Lines 543 598 +55
Branches 145 156 +11
==========================================
+ Hits 495 526 +31
- Misses 44 69 +25
+ Partials 4 3 -1
Continue to review full report at Codecov.
|
alexander-akait
approved these changes
Oct 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
better support for webpack 5
Breaking Changes
none, as webpack 5 support is experimental,
but it's notable that you must no longer pass the
hmroption when using webpack 5, as this is automatically inferred as it's using the webpack 5 HMR integrationAdditional Info