Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: serializing big strings #647

Merged
merged 2 commits into from
Nov 6, 2020
Merged

fix: serializing big strings #647

merged 2 commits into from
Nov 6, 2020

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

fixes #643

Breaking Changes

No

Additional Info

No

Copy link
Member

@sokra sokra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to be converted back to string here:

if (/^@import url/.test(m.content)) {

@codecov
Copy link

codecov bot commented Nov 5, 2020

Codecov Report

Merging #647 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #647   +/-   ##
=======================================
  Coverage   89.55%   89.55%           
=======================================
  Files          11       11           
  Lines         651      651           
  Branches      181      181           
=======================================
  Hits          583      583           
  Misses         65       65           
  Partials        3        3           
Impacted Files Coverage Δ
src/loader.js 92.03% <ø> (ø)
src/index.js 91.35% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36454c3...57f91cc. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

“Serializing big strings” warning with Webpack 5 filesystem cache
2 participants