Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use klona to avoid mutations #470

Merged

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

avoid mutation of config and options

Breaking Changes

No

Additional Info

No

@codecov
Copy link

codecov bot commented Sep 7, 2020

Codecov Report

Merging #470 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #470      +/-   ##
==========================================
+ Coverage   97.47%   97.50%   +0.02%     
==========================================
  Files           5        5              
  Lines         238      240       +2     
  Branches       73       76       +3     
==========================================
+ Hits          232      234       +2     
  Misses          6        6              
Impacted Files Coverage Δ
src/index.js 100.00% <ø> (ø)
src/utils.js 96.31% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77449e1...3dc60bd. Read the comment docs.

@alexander-akait alexander-akait merged commit cad6f07 into master Sep 7, 2020
@alexander-akait alexander-akait deleted the refactor-use-klona-to-avoid-mitation-of-options branch September 7, 2020 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant