feat: add support for node-sass v9 #1140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #1140 +/- ##
=======================================
Coverage 94.66% 94.66%
=======================================
Files 5 5
Lines 375 375
Branches 137 137
=======================================
Hits 355 355
Misses 17 17
Partials 3 3 ☔ View full report in Codecov by Sentry. |
alexander-akait
approved these changes
May 22, 2023
Closed
|
Thanks for the quick resolution. Does this need to be tweaked too? Line 16 in 19e8bdb |
|
No, other developers can use v8, v7 and etc, we can't break their projects |
AMoo-Miki
pushed a commit
to AMoo-Miki/sass-loader
that referenced
this pull request
Aug 1, 2023
(cherry picked from commit 9a03c87)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
Breaking Changes
Additional Info