Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly depend on node-sass 1.2.2 #36

Closed
appsforartists opened this issue Nov 26, 2014 · 6 comments
Closed

Explicitly depend on node-sass 1.2.2 #36

appsforartists opened this issue Nov 26, 2014 · 6 comments

Comments

@appsforartists
Copy link

npm install sass-loader@0.3.1 throws a "module did not self-register" error and fails due to an issue with node-sass 1.2.3. In the mean time, sass-loader should explicitly prefer 1.2.2.
@jhnns
Copy link
Member

jhnns commented Nov 26, 2014

Mhmmm guessing from the comments it is an issue related to node 0.11. When I run npm i sass-loader on node 0.10.33 there are no errors.

Since node 0.11 is not a stable release I don't think we need to lock the version number...

@jeffling
Copy link

1.2.3 fixes an annoying problem with compiling in CI some CI servers like travis and circle, so I would definitely prefer for it to be used.

@gpbl
Copy link

gpbl commented Feb 7, 2015

The "module did not self-register" appears also with node 0.12

@jhnns
Copy link
Member

jhnns commented Feb 9, 2015

Damn!

@gpbl
Copy link

gpbl commented Feb 9, 2015

Seems it's going to be fixed soon :) sass/node-sass#627

@jhnns
Copy link
Member

jhnns commented Mar 22, 2015

Starting with 1.0.0, node-sass is now a peerDependency

@jhnns jhnns closed this as completed Mar 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@gpbl @jeffling @jhnns @appsforartists