fix(package): add webpack >= v4.0.0 (peerDependencies)
#541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-ciniawsky
force-pushed
the
fix/peerDependencies
branch
from
631c046
to
3c836c7
Compare
michael-ciniawsky
changed the title
webpack >= v4.0.0 (peerDependencies)webpack >= v4.0.0 (peerDependencies)
package.json
Outdated
| @@ -50,24 +50,19 @@ | |||
| "webpack-merge": "^4.0.0" | |||
| }, | |||
| "engines": { | |||
| "node": ">= 4.3 < 5.0.0 || >= 5.10" | |||
| "node": ">= 4.8 < 5.0.0 || >= 5.10" | |||
There was a problem hiding this comment.
Why is this a breaking change ? But I can revert it in this PR doesn't matter...
There was a problem hiding this comment.
@michael-ciniawsky let's do it in next major 👍
| }, | ||
| "peerDependencies": { | ||
| "node-sass": "^4.0.0", | ||
| "webpack": "^2.0.0 || >= 3.0.0-rc.0 || ^3.0.0" | ||
| "webpack": "^2.0.0 || ^3.0.0 || ^4.0.0" |
There was a problem hiding this comment.
Also breaking change 😞 Let's add just ^4.0.0
There was a problem hiding this comment.
Why is this a breaking change ? Polluting this prop with alpha, beta, rc versions is really not a good idea and most folks should have updated to the latest webpack@3.0.0 by now I assumed.
There was a problem hiding this comment.
@michael-ciniawsky someone can use rc.0 and it can break build, but i agree with you
There was a problem hiding this comment.
Then it breaks :)
michael-ciniawsky
force-pushed
the
fix/peerDependencies
branch
from
3c836c7
to
8f93f13
Compare
michael-ciniawsky
added
status: Approved
and removed
pr_action: Review
priority: 3 (required)
severity: 4 (inconvenient)
status: Pending
labels
This was referenced Mar 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.