feat: source map generation depends on the `devtool` option #743

alexander-akait · 2019-08-23T13:46:48Z

This PR contains a:

Motivation / Use-Case

For better integration with webpack now we respect devtool option. If you enable source map (for example using source-map) it is enable source map generation, if you use false/eval value source map generation is disabled.

Same logic should be used for css-loader and other loader which potentially generate source map. It is steps for zre configurations

Breaking Changes

Yes, if you don't setup sourceMap option for loader, and use devtool option with any value except false/eval, source map will be generated and vice versa.

Additional Info

No

codecov · 2019-08-23T22:21:08Z

Codecov Report

Merging #743 into next will increase coverage by 0.04%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##             next     #743      +/-   ##
==========================================
+ Coverage   97.46%   97.51%   +0.04%     
==========================================
  Files           9        9              
  Lines         158      161       +3     
  Branches       55       58       +3     
==========================================
+ Hits          154      157       +3     
  Misses          4        4

Impacted Files	Coverage Δ
src/getSassOptions.js	`100% <100%> (ø)`	⬆️
src/index.js	`100% <100%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33a23f8...2e1cafa. Read the comment docs.

codecov · 2019-08-23T22:21:08Z

Codecov Report

Merging #743 into next will increase coverage by 0.04%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##             next     #743      +/-   ##
==========================================
+ Coverage   97.46%   97.51%   +0.04%     
==========================================
  Files           9        9              
  Lines         158      161       +3     
  Branches       55       58       +3     
==========================================
+ Hits          154      157       +3     
  Misses          4        4

Impacted Files	Coverage Δ
src/getSassOptions.js	`100% <100%> (ø)`	⬆️
src/index.js	`100% <100%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33a23f8...2e1cafa. Read the comment docs.

codecov · 2019-08-23T22:21:09Z

Codecov Report

Merging #743 into next will increase coverage by 0.04%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##             next     #743      +/-   ##
==========================================
+ Coverage   97.46%   97.51%   +0.04%     
==========================================
  Files           9        9              
  Lines         158      161       +3     
  Branches       55       58       +3     
==========================================
+ Hits          154      157       +3     
  Misses          4        4

Impacted Files	Coverage Δ
src/getSassOptions.js	`100% <100%> (ø)`	⬆️
src/index.js	`100% <100%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33a23f8...2e1cafa. Read the comment docs.

codecov · 2019-08-23T22:21:09Z

Codecov Report

Merging #743 into next will increase coverage by 0.04%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##             next     #743      +/-   ##
==========================================
+ Coverage   97.46%   97.51%   +0.04%     
==========================================
  Files           9        9              
  Lines         158      161       +3     
  Branches       55       58       +3     
==========================================
+ Hits          154      157       +3     
  Misses          4        4

Impacted Files	Coverage Δ
src/getSassOptions.js	`100% <100%> (ø)`	⬆️
src/index.js	`100% <100%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33a23f8...2e1cafa. Read the comment docs.

codecov · 2019-08-23T22:21:09Z

Codecov Report

Merging #743 into next will increase coverage by 0.04%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##             next     #743      +/-   ##
==========================================
+ Coverage   97.46%   97.51%   +0.04%     
==========================================
  Files           9        9              
  Lines         158      161       +3     
  Branches       55       58       +3     
==========================================
+ Hits          154      157       +3     
  Misses          4        4

Impacted Files	Coverage Δ
src/getSassOptions.js	`100% <100%> (ø)`	⬆️
src/index.js	`100% <100%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33a23f8...2e1cafa. Read the comment docs.

codecov · 2019-08-23T22:21:09Z

Codecov Report

Merging #743 into next will increase coverage by 0.04%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##             next     #743      +/-   ##
==========================================
+ Coverage   97.46%   97.51%   +0.04%     
==========================================
  Files           9        9              
  Lines         158      161       +3     
  Branches       55       58       +3     
==========================================
+ Hits          154      157       +3     
  Misses          4        4

Impacted Files	Coverage Δ
src/getSassOptions.js	`100% <100%> (ø)`	⬆️
src/index.js	`100% <100%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33a23f8...2e1cafa. Read the comment docs.

codecov · 2019-08-23T22:21:09Z

Codecov Report

Merging #743 into next will increase coverage by 0.04%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##             next     #743      +/-   ##
==========================================
+ Coverage   97.46%   97.51%   +0.04%     
==========================================
  Files           9        9              
  Lines         158      161       +3     
  Branches       55       58       +3     
==========================================
+ Hits          154      157       +3     
  Misses          4        4

Impacted Files	Coverage Δ
src/getSassOptions.js	`100% <100%> (ø)`	⬆️
src/index.js	`100% <100%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33a23f8...2e1cafa. Read the comment docs.

codecov · 2019-08-23T22:21:09Z

Codecov Report

Merging #743 into next will increase coverage by 0.04%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##             next     #743      +/-   ##
==========================================
+ Coverage   97.46%   97.51%   +0.04%     
==========================================
  Files           9        9              
  Lines         158      161       +3     
  Branches       55       58       +3     
==========================================
+ Hits          154      157       +3     
  Misses          4        4

Impacted Files	Coverage Δ
src/getSassOptions.js	`100% <100%> (ø)`	⬆️
src/index.js	`100% <100%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33a23f8...2e1cafa. Read the comment docs.

codecov · 2019-08-23T22:21:09Z

Codecov Report

Merging #743 into next will increase coverage by 0.04%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##             next     #743      +/-   ##
==========================================
+ Coverage   97.46%   97.51%   +0.04%     
==========================================
  Files           9        9              
  Lines         158      161       +3     
  Branches       55       58       +3     
==========================================
+ Hits          154      157       +3     
  Misses          4        4

Impacted Files	Coverage Δ
src/getSassOptions.js	`100% <100%> (ø)`	⬆️
src/index.js	`100% <100%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33a23f8...2e1cafa. Read the comment docs.

codecov · 2019-08-23T22:21:09Z

Codecov Report

Merging #743 into next will increase coverage by 0.04%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##             next     #743      +/-   ##
==========================================
+ Coverage   97.46%   97.51%   +0.04%     
==========================================
  Files           9        9              
  Lines         158      161       +3     
  Branches       55       58       +3     
==========================================
+ Hits          154      157       +3     
  Misses          4        4

Impacted Files	Coverage Δ
src/getSassOptions.js	`100% <100%> (ø)`	⬆️
src/index.js	`100% <100%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33a23f8...2e1cafa. Read the comment docs.

codecov · 2019-08-23T22:21:09Z

Codecov Report

Merging #743 into next will increase coverage by 0.04%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##             next     #743      +/-   ##
==========================================
+ Coverage   97.46%   97.51%   +0.04%     
==========================================
  Files           9        9              
  Lines         158      161       +3     
  Branches       55       58       +3     
==========================================
+ Hits          154      157       +3     
  Misses          4        4

Impacted Files	Coverage Δ
src/getSassOptions.js	`100% <100%> (ø)`	⬆️
src/index.js	`100% <100%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33a23f8...2e1cafa. Read the comment docs.

codecov · 2019-08-23T22:21:09Z

Codecov Report

Merging #743 into next will increase coverage by 0.04%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##             next     #743      +/-   ##
==========================================
+ Coverage   97.46%   97.51%   +0.04%     
==========================================
  Files           9        9              
  Lines         158      161       +3     
  Branches       55       58       +3     
==========================================
+ Hits          154      157       +3     
  Misses          4        4

Impacted Files	Coverage Δ
src/getSassOptions.js	`100% <100%> (ø)`	⬆️
src/index.js	`100% <100%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33a23f8...2e1cafa. Read the comment docs.

feat: source map generation depends on the devtool option

2e1cafa

alexander-akait merged commit fcea88e into next Aug 23, 2019

alexander-akait deleted the feat-source-map-generation-depends-on-the-devtool-option branch August 23, 2019 13:56

snyk-bot mentioned this pull request Nov 11, 2019

[Snyk] Upgrade sass-loader from 7.3.1 to 8.0.0 rubarb666/laravel#4

Open

vpetersson mentioned this pull request Mar 13, 2020

[Snyk] Upgrade sass-loader from 8.0.0 to 8.0.2 WoTTsecurity/api#784

Merged

This was referenced Mar 28, 2020

[Snyk] Upgrade sass-loader from 7.1.0 to 8.0.2 lwojcik/sc2pte-panel-frontend#98

Closed

[Snyk] Upgrade sass-loader from 8.0.0 to 8.0.2 DeviaVir/zenbot#2040

Merged

[Snyk] Upgrade sass-loader from 8.0.0 to 8.0.2 bangbang93/haruhi#132

Merged

This was referenced Apr 5, 2020

[Snyk] Upgrade sass-loader from 8.0.0 to 8.0.2 CollageLabs/collagelabs.org#69

Merged

[Snyk] Upgrade sass-loader from 8.0.0 to 8.0.2 the94air/twcopy#5

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: source map generation depends on the `devtool` option #743

feat: source map generation depends on the `devtool` option #743

alexander-akait commented Aug 23, 2019

codecov bot commented Aug 23, 2019 •

edited

Loading

codecov bot commented Aug 23, 2019 •

edited

Loading

codecov bot commented Aug 23, 2019

codecov bot commented Aug 23, 2019 •

edited

Loading

codecov bot commented Aug 23, 2019

codecov bot commented Aug 23, 2019

codecov bot commented Aug 23, 2019 •

edited

Loading

codecov bot commented Aug 23, 2019

codecov bot commented Aug 23, 2019

codecov bot commented Aug 23, 2019 •

edited

Loading

codecov bot commented Aug 23, 2019

codecov bot commented Aug 23, 2019

feat: source map generation depends on the devtool option #743

feat: source map generation depends on the devtool option #743

Conversation

alexander-akait commented Aug 23, 2019

Motivation / Use-Case

Breaking Changes

Additional Info

codecov bot commented Aug 23, 2019 • edited Loading

Codecov Report

codecov bot commented Aug 23, 2019 • edited Loading

Codecov Report

codecov bot commented Aug 23, 2019

Codecov Report

codecov bot commented Aug 23, 2019 • edited Loading

Codecov Report

codecov bot commented Aug 23, 2019

Codecov Report

codecov bot commented Aug 23, 2019

Codecov Report

codecov bot commented Aug 23, 2019 • edited Loading

Codecov Report

codecov bot commented Aug 23, 2019

Codecov Report

codecov bot commented Aug 23, 2019

Codecov Report

codecov bot commented Aug 23, 2019 • edited Loading

Codecov Report

codecov bot commented Aug 23, 2019

Codecov Report

codecov bot commented Aug 23, 2019

Codecov Report

feat: source map generation depends on the `devtool` option #743

feat: source map generation depends on the `devtool` option #743

codecov bot commented Aug 23, 2019 •

edited

Loading

codecov bot commented Aug 23, 2019 •

edited

Loading

codecov bot commented Aug 23, 2019 •

edited

Loading

codecov bot commented Aug 23, 2019 •

edited

Loading

codecov bot commented Aug 23, 2019 •

edited

Loading