Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: checking that the list of modules is an array #448

Merged
merged 1 commit into from
Dec 24, 2019

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

fixes #447

Breaking Changes

No

Additional Info

Supporting non-array list of modules will be removed in next version, my recommendation is #447 (comment)

@codecov
Copy link

codecov bot commented Dec 24, 2019

Codecov Report

Merging #448 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #448      +/-   ##
==========================================
+ Coverage   98.93%   98.94%   +0.01%     
==========================================
  Files           4        4              
  Lines         188      190       +2     
  Branches       85       86       +1     
==========================================
+ Hits          186      188       +2     
  Misses          2        2
Impacted Files Coverage Δ
src/runtime/injectStylesIntoStyleTag.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa418dd...ca0c56c. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v.1.1.1 throw error when accessing the page
1 participant