Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: removed cjs wrapper #265

Merged
merged 5 commits into from
Mar 21, 2022
Merged

Conversation

ricardogobbosouza
Copy link
Collaborator

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

removed cjs wrapper and generated types in commonjs format (export = and namespaces used in types), now you can directly use exported types

Breaking Changes

Potentially yes, but now we use invalid format our types

Additional Info

No

@codecov
Copy link

codecov bot commented Mar 17, 2022

Codecov Report

Merging #265 (6c64c1a) into master (fd8111a) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #265   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         7    -1     
  Lines          225       249   +24     
  Branches        53        53           
=========================================
+ Hits           225       249   +24     
Impacted Files Coverage Δ
src/StylelintError.js 100.00% <100.00%> (ø)
src/getStylelint.js 100.00% <100.00%> (ø)
src/index.js 100.00% <100.00%> (ø)
src/linter.js 100.00% <100.00%> (ø)
src/options.js 100.00% <100.00%> (ø)
src/utils.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd8111a...6c64c1a. Read the comment docs.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, will be great to verify it manually, just install from git using npm/yarn

@ricardogobbosouza ricardogobbosouza merged commit dc9a2e3 into master Mar 21, 2022
@ricardogobbosouza ricardogobbosouza deleted the feat-remove-cjs-wrapper branch March 21, 2022 13:11
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants