Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] feat: add stylelint prefix to CLI output for better debugging #279

Merged
merged 1 commit into from
May 20, 2022

Conversation

ricardogobbosouza
Copy link
Collaborator

@ricardogobbosouza ricardogobbosouza commented May 20, 2022

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

CLI output (especially errors) of stylelint-webpack-plugin are easily identifiable as coming from this plugin.

Breaking Changes

No

Additional Info

No

@codecov
Copy link

codecov bot commented May 20, 2022

Codecov Report

Merging #279 (4189012) into 2.x (e93934c) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               2.x      #279   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          221       221           
  Branches        49        49           
=========================================
  Hits           221       221           
Impacted Files Coverage Δ
src/StylelintError.js 100.00% <100.00%> (ø)
src/linter.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e93934c...4189012. Read the comment docs.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cn officially deprecated v2 and do only security fixes for v2

@ricardogobbosouza
Copy link
Collaborator Author

OK. I will just removed cjs wrapper

@ricardogobbosouza ricardogobbosouza merged commit 9e14831 into 2.x May 20, 2022
@ricardogobbosouza ricardogobbosouza deleted the 2.x-add-prefix branch May 20, 2022 15:36
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants