Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: emit warning when comment file conlict with an existing asset #156

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

emit warning to avoid broken code for some edge cases

Breaking Changes

No

Additional Info

No

@codecov
Copy link

codecov bot commented Sep 13, 2019

Codecov Report

Merging #156 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #156      +/-   ##
==========================================
+ Coverage   99.32%   99.35%   +0.03%     
==========================================
  Files           5        5              
  Lines         295      312      +17     
  Branches      116      123       +7     
==========================================
+ Hits          293      310      +17     
  Misses          2        2
Impacted Files Coverage Δ
src/index.js 99.45% <100%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efbd383...b0cddf0. Read the comment docs.

@alexander-akait alexander-akait merged commit 2b4d2a4 into master Sep 13, 2019
@alexander-akait alexander-akait deleted the feat-emit-warning-what-comment-file-conlict-with-existing-asset branch September 13, 2019 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant