Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: logic for extracting and preserving comments #166

Merged

Conversation

alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented Sep 24, 2019

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Fix logic for extracting and preserving comments

Breaking Changes

Potentially yes, but previously behavior was be invalid:

  • you can't preserve comments when use extractComment without condition
  • you can't disable preserve and extract comments
  • in some cases preserve always was some and you can't disable this

Some of bugs are very not convenient and cause problems with setup, also comments is not break code so we mark this as patch release.

Additional Info

No

@codecov
Copy link

codecov bot commented Sep 24, 2019

Codecov Report

Merging #166 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #166   +/-   ##
=======================================
  Coverage   99.36%   99.36%           
=======================================
  Files           5        5           
  Lines         313      313           
  Branches      123      125    +2     
=======================================
  Hits          311      311           
  Misses          2        2
Impacted Files Coverage Δ
src/index.js 99.45% <ø> (-0.01%) ⬇️
src/minify.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6355274...17bfe10. Read the comment docs.

@alexander-akait alexander-akait force-pushed the fix-logic-for-extracting-and-preserving-comments branch from a30b7e5 to 5424798 Compare September 24, 2019 19:53
@alexander-akait alexander-akait force-pushed the fix-logic-for-extracting-and-preserving-comments branch from 5424798 to 17bfe10 Compare September 24, 2019 20:01
@alexander-akait alexander-akait merged commit 6bdee64 into master Sep 24, 2019
@alexander-akait alexander-akait deleted the fix-logic-for-extracting-and-preserving-comments branch September 24, 2019 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant