Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(index): handle chunks provided as a {Set} #19

Merged
merged 1 commit into from
Oct 12, 2018

Conversation

ooflorent
Copy link
Contributor

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

In webpack@5, chunks is a Set and thus should be converted to an array.

Breaking Changes

n/a

Additional Info

This change makes the plugin compatible with webpack 4 and 5.

@michael-ciniawsky michael-ciniawsky changed the title fix: chunks is a Set in webpack@5 fix(index): chunks is a Set (webpack >= v5.0.0) Oct 12, 2018
@michael-ciniawsky
Copy link
Member

Do we need the (webpack >= v5.0.0) appendix for the CHANGELOG since this is backwards compatible?

@alexander-akait
Copy link
Member

@michael-ciniawsky doesn't make sense here, because first webpack versions will be alpha, beta, rc and maybe people will ask them to add too, i think better avoid it right now

@michael-ciniawsky michael-ciniawsky changed the title fix(index): chunks is a Set (webpack >= v5.0.0) fix(index): handle chunks provided as a {Set} Oct 12, 2018
@codecov
Copy link

codecov bot commented Oct 12, 2018

Codecov Report

Merging #19 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #19   +/-   ##
=======================================
  Coverage   98.45%   98.45%           
=======================================
  Files           5        5           
  Lines         259      259           
  Branches      101      101           
=======================================
  Hits          255      255           
  Misses          4        4
Impacted Files Coverage Δ
src/index.js 97.84% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abf1a4d...eaef525. Read the comment docs.

@alexander-akait alexander-akait merged commit df8c425 into master Oct 12, 2018
@alexander-akait alexander-akait deleted the fix/chunks-deprecation branch October 12, 2018 15:54
@alexander-akait
Copy link
Member

Thanks to all!

@bbrzoska
Copy link

Is this released yet?

@alexander-akait
Copy link
Member

@bbrzoska no, release planned on next week with some fixes and features

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants