Remove redundant chunkFilter #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #243 +/- ##
==========================================
- Coverage 96.02% 96.01% -0.01%
==========================================
Files 5 5
Lines 403 402 -1
Branches 151 150 -1
==========================================
- Hits 387 386 -1
Misses 16 16
Continue to review full report at Codecov.
|
|
I think 3.0.1 tag need to be released for this PR. Getting a error with 3.0.0 |
|
Why was chunkFilter removed? I need it to disable optimization for certain chunks, but now I can't. How is it redundant? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
If plugin uses minimize options from
compiler.optimization, it will fail because of default terser plugin options object. FieldchunkFilteris not allowed, but it contains in default options object.Example: https://github.com/NekR/offline-plugin/blob/66cde2c7784b5be8c84fecbb93c6f9f96faacdb5/src/service-worker.js#L106
As i see,
chunkFilternever uses in plugin, so it can be removed easily.Minimal repo to reproduce:
https://github.com/Dekkee/terser-bug
Breaking Changes
no breaking changes according to 3.0.0 release