Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(swc): adjust enableWorkerThreads #616

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kdy1
Copy link

@kdy1 kdy1 commented Jan 10, 2025

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Worker threads are actually problematic for SWC because of thread locals.

Breaking Changes

Additional Info

Copy link

CLA Not Signed

@eamodio
Copy link

eamodio commented Feb 3, 2025

@kdy1 Can this be converted to a full PR?

@kdy1 kdy1 marked this pull request as ready for review February 3, 2025 15:51
@kdy1
Copy link
Author

kdy1 commented Feb 3, 2025

Of course, I forgot to mark it as a ready for a review.
About CLA, I'll ask Vercel if I can sign it. (Although I'm pretty sure they will not care about it at all)

@alexander-akait
Copy link
Member

alexander-akait commented Feb 4, 2025

@kdy1 I think you can 😄 Ping me when you can sign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dont use workers for swc & esbuild minify
3 participants