Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: compatibility with Node.js@18 #608

Merged
merged 3 commits into from
Jul 23, 2024

Conversation

Fitz6
Copy link

@Fitz6 Fitz6 commented Jul 22, 2024

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Similar to webpack-contrib/compression-webpack-plugin#373

Related to webpack/webpack#17659.

Breaking Changes

No

Additional Info

Compatibility for Node.js@18 and allow to reuse require("crypto").createHash if webpack is lower then webpack/webpack#17628

Copy link

linux-foundation-easycla bot commented Jul 22, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

package.json Outdated Show resolved Hide resolved
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine with it, can you accept CLA?

@Fitz6
Copy link
Author

Fitz6 commented Jul 23, 2024

I am fine with it, can you accept CLA?

done.

@evenstensberg evenstensberg merged commit c47d231 into webpack-contrib:version-1 Jul 23, 2024
1 check passed
@Fitz6 Fitz6 deleted the version-1 branch July 26, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants