feat: add support for contextDependencies in the {Object} interface (options.contextDependencies)
#23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #23 +/- ##
==========================================
+ Coverage 96.15% 96.42% +0.27%
==========================================
Files 2 2
Lines 26 28 +2
Branches 7 8 +1
==========================================
+ Hits 25 27 +2
Misses 1 1
Continue to review full report at Codecov.
|
michael-ciniawsky
changed the title
contextDependencies in the {Object} interface (options.contextDependencies)
michael-ciniawsky
requested review from
jhnns,
alexander-akait and
joshwiens
joshwiens
approved these changes
Nov 16, 2017
alexander-akait
approved these changes
Nov 17, 2017
|
@jhnns Friendly ping to raise concerns @d3viant0ne @evilebottnawi Could someone please merge this within the next ~48 hours or so, I haven't write access here :) |
|
@michael-ciniawsky id don't have access as well |
joshwiens
approved these changes
Nov 19, 2017
|
@michael-ciniawsky - Published & available in Access issues should also be resolved for both of you, the push access config was missing a team. |
|
Awesome, thanks guys! |
michael-ciniawsky
added
status: Approved
and removed
priority: 5 (nice to have)
pr_action: Merge ready
status: Pending
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for declaring directories as dependencies by using
contextDependenciesin object interface returned by the generator function.Background: I've been using val-loader to generate modules based on some configuration files which are grouped in a single directory. In my generator function, I traverse that directory and parse all found configuration files adding them to the dependencies array. Problem is that in watch mode if a new file is added in that directory it will not be picked up by the webpack and I need to stop it and rerun it again.
Regarding the tests, I have simply added
contextDependenciestotest/fixtures/depenndencies.jsin order to make codecov happy :)If I need to do something more please let me know.
Hopefully, you will find this addition welcome :)