-
-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discussion: Reconsider showing breakdown of concatenated modules #188
Comments
@sokra can we do something about it? Can webpack provide more accurate data about contents of concatenated modules? |
I fear that until webpack can do dead-code elimination the same way UglifyJS can, we'll be a bit out of luck about this 😕 |
I think we should remove support for showing tree shaken module information, as it is misleading. See another example by @generalov here: facebook/create-react-app#4563 (comment) What do you think, @th0r? Should we disable this feature until we can figure out of webpack supports not showing tree-shaken modules? |
This issue has been resolved by the new v3 version 🎉 |
@valscion what does 'solved' mean? I'm new to the analyzer. I see there's a checkbox to show it but it may be inaccurate. Is that what you meant? I assume the same inaccuracies with respect to UglifyJS still apply? Thx. |
Yes there are inaccuracies but now it's communicated that inaccuracies exist, and that it is no longer the default. |
I'm opening this issue to consolidate discussion around showing contents of concatenated modules.
Original issues and implementation pull requests:
Problems and concerns related to this feature:
Quick summary of #161, quoting @mpontus #161 (comment), emphasis mine:
The crux of the issue can be summed up by @th0r's comment here #161 (comment):
Given that we are now in a situation where
webpack-bundle-analyzer
might show incorrect information instead vs. "less information", we should reconsider if the tradeoff of showing breakdown of concatenated modules contents is a good thing after all.This tradeoff can be one of the reasons why the upcoming
webpack-bundle-analyzer
support forcreate-react-app
could be removed: facebook/create-react-app#4563 (comment)/cc @bugzpodder @th0r @joshwcomeau @gaearon
The text was updated successfully, but these errors were encountered: