Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Allow JSON and HTML output at the same time. #375

Closed
leipert opened this issue Aug 11, 2020 · 15 comments
Closed

Feature Request: Allow JSON and HTML output at the same time. #375

leipert opened this issue Aug 11, 2020 · 15 comments

Comments

@leipert
Copy link

leipert commented Aug 11, 2020

Rather than adding the plugin twice with e.g.:

[
      new BundleAnalyzerPlugin({
        analyzerMode: 'static',
        openAnalyzer: false,
        reportFilename: 'webpack-report/index.html'),
      }),
      new BundleAnalyzerPlugin({
        analyzerMode: 'json',
        openAnalyzer: false,
        reportFilename: 'webpack-report/index.json'),
      }),
]

it would be nice to be able to generate JSON and HTML in one go, e.g.:

[
  new BundleAnalyzerPlugin({
    analyzerMode: "static",
    openAnalyzer: false,
    reportOutput: [
      { type: "json", fileName: "webpack-report/index.json" },
      { type: "html", fileName: "webpack-report/index.html" },
    ],
  }),
];
@leipert
Copy link
Author

leipert commented Aug 11, 2020

By the way, great work on this plugin. I don't have time right now to contribute this myself, but it would be a valuable addition to us and I just wanted to write the idea down somewhere. 😄

@leipert
Copy link
Author

leipert commented Aug 11, 2020

/cc @Gongreg

@Gongreg
Copy link
Contributor

Gongreg commented Aug 11, 2020

Hey, I think it makes sense, but we should get @valscion opinion on it :)

@valscion
Copy link
Member

Thanks for the idea! I'm not sure if this works out nicely with all the possible options configurations — it looks like we could end up with configuration that is "invalid" and we would have to write quite a lot of error handling code to deal with this situation.

@pkuczynski
Copy link

pkuczynski commented Nov 5, 2020

I believe this is possible already. Here is my example setup:

    plugins: [
        new BundleAnalyzerPlugin({
            analyzerMode: 'static',
            reportFilename: '../report/stats.html',
            statsFilename: '../report/stats.json',
            defaultSizes: 'gzip',
            generateStatsFile: true,
            openAnalyzer: false
        })
  ]]

This produces at the same time stats.html and stats.json. Is this what you wanted to achieve?

@alex-knyazev
Copy link

@

I believe this is possible already. Here is my example setup:

    plugins: [
        new BundleAnalyzerPlugin({
            analyzerMode: 'static',
            reportFilename: '../report/stats.html',
            statsFilename: '../report/stats.json',
            defaultSizes: 'gzip',
            generateStatsFile: true,
            openAnalyzer: false
        })
  ]]

This produces at the same time stats.html and stats.json. Is this what you wanted to achieve?

No, because stats.json is from webpack, report of webpuck-bundle-analyzer is different. You can see at json html and compare it with stats.json - they are different, webpack bundle analyzer report contains information only about chunks

@alex-knyazev
Copy link

alex-knyazev commented Apr 28, 2021

I think it is important feature.
I'm writing such script for two bundles comparsion:

  1. Go to git branch
  2. Build and analyze
  3. Save report to temp folder
  4. Go to other git branch
  5. Build and analyze
  6. Save report to temp folder
  7. Compare two reports.

The issue is that I want to have html reports, but I also need reports in json format to be able to compare reports.
There are no beautiful ways to do it: parse html file to get json from it or build twice using different modes.
@valscion I think it could be very goo to have ability to pass array to "mode" property:

new BundleAnalyzerPlugin({
        analyzerMode: ['json', 'static'],
}),

The expected result is to have to files in build directory: report.html and report.json.

Maybe one of the ways to make it more easy is to not add report-json inline in html (window.chartData), but include it on html page using <script> where src is 'report.json' that is in the same folder. With this changes in static and server modes we always will have json to analyze

@valscion
Copy link
Member

Hmm yeah, I think adding support for analyzerMode possibly being an array would be reasonable.

What do you think, @th0r?

@valscion
Copy link
Member

Also regarding this:

Maybe one of the ways to make it more easy is to not add report-json inline in html, but include it on html page using <script> where src is 'report.json' that is in the same folder. With this changes in static and server modes we always will have json to analyze

I don't think we need to do that. It would make the handling of report files more difficult as then the report would not be self-contained in a single HTML file anymore, like it now is. At any rate, we could discuss this change as its own change request, outside of the scope of supporting analyzerMode being an array.

@Gongreg
Copy link
Contributor

Gongreg commented Apr 28, 2021

Sorry, I don't have a lot of time currently, but as a workaround, you can also generate your own html file:

Published webpack-bundle-analyzer has a file called:
webpack-bundle-analyzer/public/viewer.js

That file tries to read window.chartData. If you create a HTML file with the json data set to the window.chartData, and include the script file it should render correctly.

@alex-knyazev
Copy link

alex-knyazev commented Apr 28, 2021

@valscion @Gongreg
For now I came to this solution:


const { getViewerData } = require("webpack-bundle-analyzer/lib/analyzer");

const stats = require("./dist/stats.json");

async function main() {
  const report = await getViewerData(stats);
  console.log(report) ; // report.json that can be used for two bundles comparing
}

main();

thanks a lot!

@th0r
Copy link
Collaborator

th0r commented Apr 28, 2021

Hmm yeah, I think adding support for analyzerMode possibly being an array would be reasonable.

Well, I think we can do that, but it will require a change to reportFilename option to be able to return different filenames for different report types e.g. allow to make it a function (reportType) => <reportFilename> (which won't work for CLI) or an object {<reportType>: <reportFilename>}. Anyway, options becomes a mess... We definitely need to ship a new major version with completely revised API with pluggable external reporters.

@valscion
Copy link
Member

@valscion @Gongreg
For now I came to this solution:


const { getViewerData } = require("webpack-bundle-analyzer/lib/analyzer");

const stats = require("./dist/stats.json");

async function main() {
  const report = await getViewerData(stats);
  console.log(report) ; // report.json that can be used for two bundles comparing
}

main();

thanks a lot!

Do note that you are relying on internal logic and this logic can break even in patch releases. I'm glad that it works for you, though ☺️

We definitely need to ship a new major version with completely revised API with pluggable external reporters.

Yeah, this does indeed sound like it.

So this isn't a trivial update in the end. It would require quite a lot of effort, so don't hold your breath 😅

@leipert
Copy link
Author

leipert commented May 5, 2021

@valscion Submitted a PR with a backwards-compatible implementation: #442

@langri-sha
Copy link

Really looking forward to this! For now it seems we either have to resort to adding the plugin twice, or disabling it to generate the stats file and then using the CLI.

@webpack-contrib webpack-contrib locked and limited conversation to collaborators Feb 23, 2023
@valscion valscion converted this issue into discussion #573 Feb 23, 2023

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Projects
None yet
Development

No branches or pull requests

7 participants