fix: match mutliple dashes (`options.camelCase`) #556

sanpoChew · 2017-06-13T15:25:01Z

What kind of change does this PR introduce?
Regex tweak for matching dashes in class names.

Did you add tests for your changes?
No

Summary
I was running into the same issue as #244 whereby classes with double dashes in it still had one dash left even though I have camelCase set to 'dashes'. All I've done is change the regex to match one or more dashes and remove them all.

Does this PR introduce a breaking change?
Not to my knowledge, all tests pass.

jsf-clabot · 2017-06-13T15:25:04Z

All committers have signed the CLA.

alexander-akait · 2017-06-13T15:26:12Z

lib/compile-exports.js

@@ -1,7 +1,7 @@
 var camelCase = require("lodash.camelcase");

 function dashesCamelCase(str) {
-  return str.replace(/-(\w)/g, function(match, firstLetter) {
+  return str.replace(/-{1,}(\w)/g, function(match, firstLetter) {


Use + modifier

codecov · 2017-06-13T15:28:14Z

Codecov Report

Merging #556 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #556   +/-   ##
=======================================
  Coverage   98.63%   98.63%           
=======================================
  Files          10       10           
  Lines         367      367           
  Branches       87       87           
=======================================
  Hits          362      362           
  Misses          5        5

Impacted Files	Coverage Δ
lib/compile-exports.js	`100% <100%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c13c467...9e3e7d5. Read the comment docs.

michael-ciniawsky

@sanpoChew Please add a test :)

michael-ciniawsky · 2017-06-13T15:39:53Z

Fixes #244

sanpoChew · 2017-06-13T15:49:52Z

@evilebottnawi @michael-ciniawsky added a test

@TrySound changed to the plus modifier instead, not that well versed with regexes!

michael-ciniawsky

Thx

joshwiens · 2017-06-13T15:52:29Z

Still needs to sign the CLA

michael-ciniawsky · 2017-06-13T15:52:54Z

Joseph Bushell seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

Is your current Git Email (git.config) different from the Email you use for your github account ?

joshwiens · 2017-06-13T16:00:42Z

Is your current Git Email (git.config) different from the Email you use for your github account ?

Without a doubt. @sanpoChew You will have to ensure your git config & github emails match.

Then ....

Fix the commit meta using the proper email, then close & open this PR

or ...

Open another pull request from an entirely new branch. Depending on cli git skills, this is sometimes easier for people.

sanpoChew · 2017-06-13T16:16:34Z

@michael-ciniawsky @d3viant0ne yeah I did this at work and didn't have an email set on git, just fixed it and signed it

sanpoChew · 2017-06-13T16:34:46Z

very cool! First time contributing to anything, cheers for the help guys

jonathancalb · 2018-03-12T14:40:49Z

Hello, I updated to css-loader 28.10 and still have this bug when using 'react-transition-group'.

alexander-akait · 2018-03-12T14:47:11Z

@jonathancalb please create new issue with minimum reproducible test repo

jonathancalb · 2018-03-13T14:39:15Z

Finally, researching a little more. I find out that the exported css was ok. The class dynamically added was wrong, so maybe it was not a css loader bug. I fixed it with the solution in this thread: css-modules/css-modules#84 specifying the enterActive and leaveActive properties of CSSTransitionGroup.

This Pull Request updates dependency [css-loader](https://github.com/webpack-contrib/css-loader) from `^0.28.11` to `^1.0.0` <details> <summary>Release Notes</summary> ### [`v1.0.0`](https://github.com/webpack-contrib/css-loader/blob/master/CHANGELOG.md#100httpsgithubcomwebpack-contribcss-loadercomparev02811v100-2018-07-06) [Compare Source](webpack-contrib/css-loader@v0.28.11...v1.0.0) ##### BREAKING CHANGES * remove `minimize` option, use [`postcss-loader`](https://github.com/postcss/postcss-loader) with [`cssnano`](https://github.com/cssnano/cssnano) or use [`optimize-cssnano-plugin`](https://github.com/intervolga/optimize-cssnano-plugin) plugin * remove `module` option, use `modules` option instead * remove `camelcase` option, use `camelCase` option instead * remove `root` option, use [`postcss-loader`](https://github.com/postcss/postcss-loader) with [`postcss-url`](https://github.com/postcss/postcss-url) plugin * remove `alias` option, use [`resolve.alias`](https://webpack.js.org/configuration/resolve/) feature or use [`postcss-loader`](https://github.com/postcss/postcss-loader) with [`postcss-url`](https://github.com/postcss/postcss-url) plugin * update `postcss` to `6` version * minimum require `nodejs` version is `6.9` * minimum require `webpack` version is `4` #### [0.28.11](webpack-contrib/css-loader@v0.28.10...v0.28.11) (2018-03-16) ##### Bug Fixes * **lib/processCss:** don't check `mode` for `url` handling (`options.modules`) ([#698](`https://github.com/webpack-contrib/css-loader/issues/698`)) ([c788450](webpack-contrib/css-loader@c788450)) #### [0.28.10](webpack-contrib/css-loader@v0.28.9...v0.28.10) (2018-02-22) ##### Bug Fixes * **getLocalIdent:** add `rootContext` support (`webpack >= v4.0.0`) ([#681](`https://github.com/webpack-contrib/css-loader/issues/681`)) ([9f876d2](webpack-contrib/css-loader@9f876d2)) #### [0.28.9](webpack-contrib/css-loader@v0.28.8...v0.28.9) (2018-01-17) ##### Bug Fixes * ignore invalid URLs (`url()`) ([#663](`https://github.com/webpack-contrib/css-loader/issues/663`)) ([d1d8221](webpack-contrib/css-loader@d1d8221)) #### [0.28.8](webpack-contrib/css-loader@v0.28.7...v0.28.8) (2018-01-05) ##### Bug Fixes * **loader:** correctly check if source map is `undefined` ([#641](`https://github.com/webpack-contrib/css-loader/issues/641`)) ([0dccfa9](webpack-contrib/css-loader@0dccfa9)) * proper URL escaping and wrapping (`url()`) ([#627](`https://github.com/webpack-contrib/css-loader/issues/627`)) ([8897d44](webpack-contrib/css-loader@8897d44)) #### [0.28.7](webpack-contrib/css-loader@v0.28.6...v0.28.7) (2017-08-30) ##### Bug Fixes * pass resolver to `localsLoader` (`options.alias`) ([#601](`https://github.com/webpack/css-loader/issues/601`)) ([8f1b57c](webpack-contrib/css-loader@8f1b57c)) #### [0.28.6](webpack-contrib/css-loader@v0.28.5...v0.28.6) (2017-08-30) ##### Bug Fixes * add support for aliases starting with `/` (`options.alias`) ([#597](`https://github.com/webpack/css-loader/issues/597`)) ([63567f2](webpack-contrib/css-loader@63567f2)) #### [0.28.5](webpack-contrib/css-loader@v0.28.4...v0.28.5) (2017-08-17) ##### Bug Fixes * match mutliple dashes (`options.camelCase`) ([#556](`https://github.com/webpack/css-loader/issues/556`)) ([1fee601](webpack-contrib/css-loader@1fee601)) * stricter `[@import]` tolerance ([#593](`https://github.com/webpack/css-loader/issues/593`)) ([2e4ec09](webpack-contrib/css-loader@2e4ec09)) #### [0.28.4](webpack-contrib/css-loader@v0.28.3...v0.28.4) (2017-05-30) ##### Bug Fixes * preserve leading underscore in class names ([#543](`https://github.com/webpack/css-loader/issues/543`)) ([f6673c8](webpack-contrib/css-loader@f6673c8)) #### [0.28.3](webpack-contrib/css-loader@v0.28.2...v0.28.3) (2017-05-25) ##### Bug Fixes * correct plugin order for CSS Modules ([#534](`https://github.com/webpack/css-loader/issues/534`)) ([b90f492](webpack-contrib/css-loader@b90f492)) #### [0.28.2](webpack-contrib/css-loader@v0.28.1...v0.28.2) (2017-05-22) ##### Bug Fixes * source maps path on `windows` ([#532](`https://github.com/webpack/css-loader/issues/532`)) ([c3d0d91](webpack-contrib/css-loader@c3d0d91)) #### [0.28.1](webpack-contrib/css-loader@v0.28.0...v0.28.1) (2017-05-02) ##### Bug Fixes * allow to specify a full hostname as a root URL ([#521](`https://github.com/webpack/css-loader/issues/521`)) ([06d27a1](webpack-contrib/css-loader@06d27a1)) * case insensitivity of [@import] ([#514](`https://github.com/webpack/css-loader/issues/514`)) ([de4356b](webpack-contrib/css-loader@de4356b)) * don't handle empty [@import] and url() ([#513](`https://github.com/webpack/css-loader/issues/513`)) ([868fc94](webpack-contrib/css-loader@868fc94)) * imported variables are replaced in exports if followed by a comma ([#504](`https://github.com/webpack/css-loader/issues/504`)) ([956bad7](webpack-contrib/css-loader@956bad7)) * loader now correctly handles `url` with space(s) ([#495](`https://github.com/webpack/css-loader/issues/495`)) ([534ea55](webpack-contrib/css-loader@534ea55)) * url with a trailing space is now handled correctly ([#494](`https://github.com/webpack/css-loader/issues/494`)) ([e1ec4f2](webpack-contrib/css-loader@e1ec4f2)) * use `btoa` instead `Buffer` ([#501](`https://github.com/webpack/css-loader/issues/501`)) ([fbb0714](webpack-contrib/css-loader@fbb0714)) ##### Performance Improvements * generate source maps only when explicitly set ([#478](`https://github.com/webpack/css-loader/issues/478`)) ([b8f5c8f](webpack-contrib/css-loader@b8f5c8f)) --- </details> --- This PR has been generated by [Renovate Bot](https://renovatebot.com).

matching one dash or more

cc70af2

alexander-akait requested changes Jun 13, 2017

View reviewed changes

michael-ciniawsky changed the title ~~matching one dash or more~~ fix: match mutliple dashes (options.camelCase) Jun 13, 2017

michael-ciniawsky added priority: 4 (important) pr_action: Review semver: Patch severity: 4 (inconvenient) type: Bug labels Jun 13, 2017

michael-ciniawsky added this to the 0.28.5 milestone Jun 13, 2017

michael-ciniawsky requested a review from TrySound June 13, 2017 15:38

michael-ciniawsky approved these changes Jun 13, 2017

View reviewed changes

michael-ciniawsky added the flag: Needs Tests label Jun 13, 2017

Joseph Bushell added 2 commits June 13, 2017 16:44

added tests

5c6d8b0

use plus modifier

9e3e7d5

michael-ciniawsky approved these changes Jun 13, 2017

View reviewed changes

michael-ciniawsky added pr_action: Merge ready status: Blocked and removed flag: Needs Tests pr_action: Review labels Jun 13, 2017

TrySound approved these changes Jun 13, 2017

View reviewed changes

alexander-akait approved these changes Jun 13, 2017

View reviewed changes

michael-ciniawsky added status: Approved and removed pr_action: Merge ready status: Blocked labels Jun 13, 2017

michael-ciniawsky merged commit 1fee601 into webpack-contrib:master Jun 13, 2017

michael-ciniawsky modified the milestone: 0.28.6 Aug 17, 2017

snyk-bot mentioned this pull request Aug 16, 2019

[Snyk] Upgrade css-loader from 0.23.1 to 0.28.11 DriveClutch/sellpy-dockerfiles#4

Closed

snyk-bot mentioned this pull request Jan 8, 2020

[Snyk] Upgrade css-loader from 0.17.0 to 0.28.11 timscharfenort/kibana#3

Open

This was referenced Jan 22, 2020

[Snyk] Upgrade css-loader from 0.23.1 to 0.28.11 anyulled/Learn-Redux-Starter-Files#1

Open

[Snyk] Upgrade css-loader from 0.24.0 to 0.28.11 anyulled/react-skeleton#2

Closed

This was referenced Feb 23, 2020

[Snyk] Upgrade css-loader from 0.26.4 to 0.28.11 saurabharch/stitch-examples#2

Open

[Snyk] Upgrade css-loader from 0.23.1 to 0.28.11 saurabharch/guesstimate-app#3

Open

[Snyk] Upgrade css-loader from 0.23.1 to 0.28.11 saurabharch/CodeGenius#2

Open

snyk-bot mentioned this pull request Mar 7, 2020

[Snyk] Upgrade css-loader from 0.23.1 to 0.28.11 yowainwright/react-workshop#4

Closed

This was referenced Apr 2, 2020

[Snyk] Upgrade css-loader from 0.26.4 to 0.28.11 fiverr/rollout_dashboard#48

Open

[Snyk] Upgrade css-loader from 0.19.0 to 0.28.11 rangle/react-day-picker#2

Open

snyk-bot mentioned this pull request Apr 24, 2020

[Snyk] Upgrade css-loader from 0.16.0 to 0.28.11 walmartlabs/bolt-standard-flux#3

Open

This was referenced May 4, 2020

[Snyk] Upgrade css-loader from 0.23.1 to 0.28.11 Barnstorm-Online/votetracker#1

Open

[Snyk] Upgrade css-loader from 0.23.1 to 0.28.11 React-Junkie/react-coffee-and-friends#2

Open

KrisPeachyKen mentioned this pull request Jul 30, 2024

[Snyk] Upgrade css-loader from 0.18.0 to 0.28.11 KrisPeachyKen/ai#2

Open

superadmiral mentioned this pull request Jul 30, 2024

[Snyk] Upgrade css-loader from 0.18.0 to 0.28.11 superadmiral/ai#2

Open

YinghanFeng mentioned this pull request Aug 2, 2024

[Snyk] Upgrade css-loader from 0.9.1 to 0.28.11 YinghanFeng/deco-ide#1

Open

go-benchmark1 mentioned this pull request Aug 16, 2024

[Snyk] Upgrade css-loader from 0.23.1 to 0.28.11 go-benchmark1/pome#1

Open

Vishesh7797 mentioned this pull request Oct 26, 2024

[Snyk] Upgrade css-loader from 0.26.4 to 0.28.11 Vishesh7797/Sorting-Visualizer#2

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: match mutliple dashes (`options.camelCase`) #556

fix: match mutliple dashes (`options.camelCase`) #556

sanpoChew commented Jun 13, 2017

jsf-clabot commented Jun 13, 2017 •

edited

Loading

alexander-akait Jun 13, 2017

TrySound Jun 13, 2017

codecov bot commented Jun 13, 2017 •

edited

Loading

michael-ciniawsky left a comment

michael-ciniawsky commented Jun 13, 2017

sanpoChew commented Jun 13, 2017

michael-ciniawsky left a comment

joshwiens commented Jun 13, 2017

michael-ciniawsky commented Jun 13, 2017

joshwiens commented Jun 13, 2017

sanpoChew commented Jun 13, 2017

sanpoChew commented Jun 13, 2017

jonathancalb commented Mar 12, 2018 •

edited

Loading

alexander-akait commented Mar 12, 2018 •

edited

Loading

jonathancalb commented Mar 13, 2018

fix: match mutliple dashes (options.camelCase) #556

fix: match mutliple dashes (options.camelCase) #556

Conversation

sanpoChew commented Jun 13, 2017

jsf-clabot commented Jun 13, 2017 • edited Loading

alexander-akait Jun 13, 2017

Choose a reason for hiding this comment

TrySound Jun 13, 2017

Choose a reason for hiding this comment

codecov bot commented Jun 13, 2017 • edited Loading

Codecov Report

michael-ciniawsky left a comment

Choose a reason for hiding this comment

michael-ciniawsky commented Jun 13, 2017

sanpoChew commented Jun 13, 2017

michael-ciniawsky left a comment

Choose a reason for hiding this comment

joshwiens commented Jun 13, 2017

michael-ciniawsky commented Jun 13, 2017

joshwiens commented Jun 13, 2017

sanpoChew commented Jun 13, 2017

sanpoChew commented Jun 13, 2017

jonathancalb commented Mar 12, 2018 • edited Loading

alexander-akait commented Mar 12, 2018 • edited Loading

jonathancalb commented Mar 13, 2018

fix: match mutliple dashes (`options.camelCase`) #556

fix: match mutliple dashes (`options.camelCase`) #556

jsf-clabot commented Jun 13, 2017 •

edited

Loading

codecov bot commented Jun 13, 2017 •

edited

Loading

jonathancalb commented Mar 12, 2018 •

edited

Loading

alexander-akait commented Mar 12, 2018 •

edited

Loading