This repository has been archived by the owner on Mar 17, 2021. It is now read-only.
refactor: Apply webpack-defaults #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's in the preset now.
This avoids `require('file-loader').default`.
- It is no longer necessary to transpile es6 to cjs
Codecov Report
@@ Coverage Diff @@
## master #167 +/- ##
=========================================
Coverage ? 97.43%
=========================================
Files ? 2
Lines ? 39
Branches ? 18
=========================================
Hits ? 38
Misses ? 1
Partials ? 0
Continue to review full report at Codecov.
|
This was referenced Oct 29, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Did you add tests for your changes?
If relevant, did you update the README?
Summary
This PR integrates webpack-defaults to the project.
Does this PR introduce a breaking change?
Yes. Will enforce NodeJS > 4.3 via engines.
Must release as semver
MAJOROther information
What kind of change does this PR introduce?
Refactoring.
Did you add tests for your changes?
The old tests should work.
Closes #148