This repository has been archived by the owner on Aug 20, 2018. It is now read-only.
docs(README): add warning about webpack 2 usage #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the note, that this loader's functionality is on by default in Webpack 2, is not visible in the [documentation page](https://webpack.js.org/loaders/json-loader/#components/sidebar/sidebar.jsx). Moved it under its own section, hoping it'll now be visible
michael-ciniawsky
suggested changes
Apr 13, 2017
README.md
Outdated
| **Note: Since webpack v2, JSON files will work by default. You might still want to use this if you use a custom file extension.** | ||
| <h2 align="center">Note</h2> | ||
|
|
||
| **Since webpack v2, JSON files will work by default. You might still want to use this if you use a custom file extension.** |
There was a problem hiding this comment.
You could add Install section, but please don't add another top-level section, since we try to achieve docs consistency accross webpack-contrib
Also tweaked the text a little, for clarity
|
@michael-ciniawsky Updated, let me know if it is ok now! |
bebraw
approved these changes
May 7, 2017
michael-ciniawsky
changed the title
joshwiens
pushed a commit
that referenced
this pull request
Jul 22, 2017
joshwiens
pushed a commit
that referenced
this pull request
Jul 22, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the note, that this loader's functionality is on by default in Webpack 2, is not visible in the documentation page.
Moved it under its own section, hoping it'll now be visible.