fix: work with source maps when wrapped (mocha-env-loader)
#238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
* Work with source maps * Avoid calling callback twice
|
Ran into this issue today, is there any updates on this? I have been making changes to our webpack config and its using the array format now for different bundle outputs. |
michael-ciniawsky
changed the title
mocha-env-loader)
joshwiens
approved these changes
Oct 11, 2017
joshwiens
added
pr_action: Merge ready
status: Approved
and removed
pr_action: Review
status: Pending
labels
alexander-akait
approved these changes
Oct 11, 2017
|
Let me know if you need anything else from me here. |
This was referenced Nov 17, 2017
mattlewis92
pushed a commit
that referenced
this pull request
Dec 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notable Changes
When mocha is wrapped and a sourcemap is present, the
mocha-env-loadertries to callSourceNode.fromSourceWithMap(content, map).The
SourceNode.fromSourceWithMap()function isn't defined insource-map@0.1.41(I'm not sure if it was ever part of that library).I've updated the dependency to
source-map@0.5.6and adapted the code to the new API.This gets rid of the
TypeError: SourceNode.fromSourceWithMap is not a functionfrom the log and revealsError: callback(): The callback was already called.instead. Assuming the intention was to return after calling the callback, I added a return.Code
See https://gist.github.com/tschaub/b7700159dad789c4a0b91f2038dd0f58 for steps to reproduce.
Issues