From 1055c845f63748fb78598b6312d06d923de9f2bc Mon Sep 17 00:00:00 2001
From: igio <iguessitsokaythen@gmail.com>
Date: Tue, 16 Feb 2021 17:00:14 +0000
Subject: [PATCH 1/2] fix: set withConfig return type to include correct
 properties

Current behavior:

withConfig return type
- does contain callAsync, which doesn't exist
- doesn't contain tapAsync or tapPromise, which does exist

Expected behavior:

withConfig return type
- should be limited to return value in source
- should include properties depends on the current child instance

related withConfig source code: https://github.com/webpack/tapable/blob/413fa785018406464963c29d172e06d2df42f22e/lib/Hook.js#L105
---
 tapable.d.ts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tapable.d.ts b/tapable.d.ts
index d77f31b..5d52646 100644
--- a/tapable.d.ts
+++ b/tapable.d.ts
@@ -63,7 +63,7 @@ declare class Hook<T, R, AdditionalOptions = UnsetAdditionalOptions> {
 	callAsync(...args: Append<AsArray<T>, Callback<Error, R>>): void;
 	promise(...args: AsArray<T>): Promise<R>;
 	tap(options: string | Tap & IfSet<AdditionalOptions>, fn: (...args: AsArray<T>) => R): void;
-	withOptions(options: TapOptions & IfSet<AdditionalOptions>): Hook<T, R>;
+	withOptions(options: TapOptions & IfSet<AdditionalOptions>): Omit<this, 'call' | 'callAsync'>;
 }
 
 export class SyncHook<T, R = void, AdditionalOptions = UnsetAdditionalOptions> extends Hook<T, R, AdditionalOptions> {

From 0ab826bdb6aacf08b09fb20a8aeac14999f1695b Mon Sep 17 00:00:00 2001
From: Ferdi <iguessitsokaythen@gmail.com>
Date: Wed, 17 Feb 2021 12:18:35 +0000
Subject: [PATCH 2/2] omit promise field and fix linting

Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>
---
 tapable.d.ts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tapable.d.ts b/tapable.d.ts
index 5d52646..c2897a5 100644
--- a/tapable.d.ts
+++ b/tapable.d.ts
@@ -63,7 +63,7 @@ declare class Hook<T, R, AdditionalOptions = UnsetAdditionalOptions> {
 	callAsync(...args: Append<AsArray<T>, Callback<Error, R>>): void;
 	promise(...args: AsArray<T>): Promise<R>;
 	tap(options: string | Tap & IfSet<AdditionalOptions>, fn: (...args: AsArray<T>) => R): void;
-	withOptions(options: TapOptions & IfSet<AdditionalOptions>): Omit<this, 'call' | 'callAsync'>;
+	withOptions(options: TapOptions & IfSet<AdditionalOptions>): Omit<this, "call" | "callAsync" | "promise">;
 }
 
 export class SyncHook<T, R = void, AdditionalOptions = UnsetAdditionalOptions> extends Hook<T, R, AdditionalOptions> {