fix: set withOptions return type to include correct properties #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current behavior: withConfig return type - does contain callAsync, which doesn't exist - doesn't contain tapAsync or tapPromise, which does exist Expected behavior: withConfig return type - should be limited to return value in source - should include properties depends on the current child instance related withConfig source code: https://github.com/webpack/tapable/blob/413fa785018406464963c29d172e06d2df42f22e/lib/Hook.js#L105
iguessitsokay
changed the title
sokra
requested changes
Feb 17, 2021
Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current behavior:
withOptions return type
Expected behavior:
withOptions return type
related withOptions source code:
tapable/lib/Hook.js
Line 105 in 413fa78