From e4a6b7bf94776832afb948389b4ec7bf63f9911d Mon Sep 17 00:00:00 2001
From: Nitin Kumar <46647141+snitin315@users.noreply.github.com>
Date: Sat, 23 May 2020 12:41:19 +0530
Subject: [PATCH] refactor:  remove plugin flag (#1571)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

BREAKING CHANGE: 🧨 removed --plugin without any replacement

Co-authored-by: Anshuman Verma <anshu.av97@gmail.com>
---
 packages/webpack-cli/README.md                |  1 -
 .../webpack-cli/lib/groups/AdvancedGroup.js   | 44 -------------------
 packages/webpack-cli/lib/utils/cli-flags.js   |  8 ----
 3 files changed, 53 deletions(-)

diff --git a/packages/webpack-cli/README.md b/packages/webpack-cli/README.md
index 06942dd7437..b0e9214b497 100644
--- a/packages/webpack-cli/README.md
+++ b/packages/webpack-cli/README.md
@@ -42,7 +42,6 @@ Options
   --silent                 Disable any output that webpack makes
   --help                   Outputs list of supported flags
   -o, --output string      Output location of the file generated by webpack
-  --plugin string          Load a given plugin
   -t, --target string      Sets the build target
   -w, --watch              Watch for files changes
   -h, --hot                Enables Hot Module Replacement
diff --git a/packages/webpack-cli/lib/groups/AdvancedGroup.js b/packages/webpack-cli/lib/groups/AdvancedGroup.js
index dcedc86bf4c..64a5bc17800 100644
--- a/packages/webpack-cli/lib/groups/AdvancedGroup.js
+++ b/packages/webpack-cli/lib/groups/AdvancedGroup.js
@@ -4,43 +4,6 @@ class AdvancedGroup extends GroupHelper {
     constructor(options) {
         super(options);
     }
-    // TODO: fixme. This function is requiring modules that are not installed
-    // loadPlugin(name) {
-    //     const loadUtils = require('loader-utils');
-    //     let args;
-    //     try {
-    //         const p = name && name.indexOf('?');
-    //         if (p > -1) {
-    //             args = loadUtils.parseQuery(name.substring(p));
-    //             name = name.substring(0, p);
-    //         }
-    //     } catch (e) {
-    //         logger.error('Invalid plugin arguments ' + name + ' (' + e + ').');
-    //         process.exit(-1); // eslint-disable-line
-    //     }
-    //
-    //     let path;
-    //     try {
-    //         const resolve = require('enhanced-resolve');
-    //         path = resolve.sync(process.cwd(), name);
-    //     } catch (e) {
-    //         logger.error('Cannot resolve plugin ' + name + '.');
-    //         process.exit(-1); // eslint-disable-line
-    //     }
-    //     let Plugin;
-    //     try {
-    //         Plugin = require(path);
-    //     } catch (e) {
-    //         logger.error('Cannot load plugin ' + name + '. (' + path + ')');
-    //         throw e;
-    //     }
-    //     try {
-    //         return new Plugin(args);
-    //     } catch (e) {
-    //         logger.error('Cannot instantiate plugin ' + name + '. (' + path + ')');
-    //         throw e;
-    //     }
-    // }
     resolveOptions() {
         const {
             args,
@@ -66,13 +29,6 @@ class AdvancedGroup extends GroupHelper {
                 // options.plugins = [prefetchVal];
             }
         }
-        if (args.plugin) {
-            if (options && options.plugins) {
-                options.plugins.unshift(this.loadPlugin(args.plugin));
-            } else {
-                options.plugins = [this.loadPlugin(args.plugin)];
-            }
-        }
         if (args.target) {
             options.target = args.target;
         }
diff --git a/packages/webpack-cli/lib/utils/cli-flags.js b/packages/webpack-cli/lib/utils/cli-flags.js
index 540900a9ca8..b0c0cb32bdb 100644
--- a/packages/webpack-cli/lib/utils/cli-flags.js
+++ b/packages/webpack-cli/lib/utils/cli-flags.js
@@ -128,14 +128,6 @@ module.exports = {
             description: 'Output location of the file generated by webpack e.g. ./dist/',
             link: 'https://webpack.js.org/concepts/#output',
         },
-        {
-            name: 'plugin',
-            usage: '--plugin <pluginName>',
-            group: ADVANCED_GROUP,
-            type: String,
-            description: 'Load a given plugin e.g. HtmlWebpackPlugin',
-            link: 'https://webpack.js.org/plugins/',
-        },
         {
             name: 'target',
             usage: '--target <value>',