From e68619d6d8e9b717385ce29307caf589e5233828 Mon Sep 17 00:00:00 2001 From: Anshuman Verma Date: Tue, 4 Aug 2020 21:27:40 +0530 Subject: [PATCH] fix: conditionally install terser-webpack-plugin for webpack@next (#1732) --- .github/workflows/nodejs.yml | 4 ++++ test/core-flags/optimization-flags.test.js | 6 ++++++ 2 files changed, 10 insertions(+) diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml index 34c1e355b8a..a084704486c 100644 --- a/.github/workflows/nodejs.yml +++ b/.github/workflows/nodejs.yml @@ -75,6 +75,10 @@ jobs: - name: Install webpack ${{ matrix.webpack-version }} run: yarn add -W webpack@${{ matrix.webpack-version }} + - name: Install latest terser-webpack-plugin for webpack 5 + if: ${{ matrix.webpack-version == 'next' }} + run: yarn add -W terser-webpack-plugin --dev + - name: Build run: yarn build diff --git a/test/core-flags/optimization-flags.test.js b/test/core-flags/optimization-flags.test.js index 22502dfe87f..758c7f7770b 100644 --- a/test/core-flags/optimization-flags.test.js +++ b/test/core-flags/optimization-flags.test.js @@ -46,6 +46,12 @@ describe('optimization config related flag', () => { if (flag.name === 'optimization-split-chunks-chunks') { stdout = run(__dirname, [`--${flag.name}`, 'initial']).stdout; expect(stdout).toContain(`chunks: 'initial'`); + } else if (flag.name === 'optimization-mangle-exports') { + stdout = run(__dirname, ['--optimization-mangle-exports', 'size']).stdout; + expect(stdout).toContain(`mangleExports: 'size'`); + } else if (flag.name === 'optimization-used-exports') { + stdout = run(__dirname, ['--optimization-used-exports', 'global']).stdout; + expect(stdout).toContain(`usedExports: 'global'`); } else { expect(stdout).toContain(`${propName}: 'named'`); }