fix: Install correct (es2015) babel preset to match generated config
#138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The config generated uses `presets: ['es2015']`, see: https://github.com/webpack/webpack-cli/blob/master/lib/creator/yeoman/utils/module.js#L8 ... but are previously installing `babel-preset-env` instead, which causes error when user answers `y` to 'Will you be using ES2015?', then runs `webpack`.
evenstensberg
approved these changes
May 13, 2017
|
Thanks! Sorry I did mention that this was outstanding in the last comment in that issue. I wasn't sure what the intended babel preset was at the time, but it became clear this is the only fix that made sense after a bit of reading into babel-preset-env, and sleep 😀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bugfix
Did you add tests for your changes?
No (none in repo)
If relevant, did you update the documentation?
N/A
Summary
Raised in #135, but I didn't address this outstanding problem in the previous PR.
The config generated uses
presets: ['es2015'], see: https://github.com/webpack/webpack-cli/blob/master/lib/creator/yeoman/utils/module.js#L8... but are previously installing
babel-preset-envinstead, which results in:Error: Couldn't find preset "es2015"when user answers'y'to 'Will you be using ES2015?', then runswebpack.Does this PR introduce a breaking change?
No