Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: delegate default entry assigning to core #1852

Closed
anshumanv opened this issue Oct 2, 2020 · 2 comments · Fixed by #1856
Closed

[Bug]: delegate default entry assigning to core #1852

anshumanv opened this issue Oct 2, 2020 · 2 comments · Fixed by #1856
Assignees
@anshumanv
Labels
Bug

Comments

@anshumanv
Copy link
Member

Describe the bug

Presently we assign our own default entry which is invalid since it can be ts/mjs etc so delegate this to core, we only need to assign entry when user passes

What is the current behavior?

Entry assigned to index.js or src/index.js

To Reproduce
Add some non js index file then it won't work

Expected behavior
It should work

Screenshots

Please paste the results of webpack-cli info here, and mention other relevant information

Additional context
@anshumanv anshumanv added the Bug label Oct 2, 2020
@anshumanv anshumanv self-assigned this Oct 2, 2020
@anshumanv anshumanv mentioned this issue Oct 2, 2020
Merged
@alexander-akait
Copy link
Member

@anshumanv Can you send a PR, it is very important

@anshumanv
Copy link
Member Author

yep on it 👍

@anshumanv anshumanv mentioned this issue Oct 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anshumanv anshumanv

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: defer setting default entry to core anshumanv/webpack-cli
2 participants
@alexander-akait @anshumanv