Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(init): remove --force flag #2391

Merged
merged 1 commit into from
Feb 1, 2021

Conversation

jamesgeorge007
Copy link
Member

@jamesgeorge007 jamesgeorge007 commented Feb 1, 2021

What kind of change does this PR introduce?
chore

Did you add tests for your changes?
Remove stale tests.

If relevant, did you update the documentation?
Yup.

Summary
webpack init generates a webpack-config file by default, and the --force flag doesn't serve any purpose.

Does this PR introduce a breaking change?
The --force flag isn't recognized anymore.

Other information
N/A

@jamesgeorge007 jamesgeorge007 requested a review from a team as a code owner February 1, 2021 07:58
@codecov
Copy link

codecov bot commented Feb 1, 2021

Codecov Report

Merging #2391 (af5f4f7) into master (9d6dbda) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2391   +/-   ##
=======================================
  Coverage   71.26%   71.27%           
=======================================
  Files          46       46           
  Lines        2158     2155    -3     
  Branches      570      568    -2     
=======================================
- Hits         1538     1536    -2     
+ Misses        620      619    -1     
Impacted Files Coverage Δ
...kages/generators/src/utils/modify-config-helper.ts 57.14% <100.00%> (-0.76%) ⬇️
packages/generators/src/utils/scaffold.ts 77.55% <100.00%> (+1.08%) ⬆️
packages/init/src/index.ts 88.88% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d6dbda...af5f4f7. Read the comment docs.

@jamesgeorge007 jamesgeorge007 merged commit 7bd747a into webpack:master Feb 1, 2021
@jamesgeorge007 jamesgeorge007 deleted the init-force branch February 1, 2021 10:30
snitin315 pushed a commit to snitin315/webpack-cli that referenced this pull request Feb 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants