Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use conventional commitlint #2394

Merged
merged 2 commits into from
Feb 2, 2021
Merged

Conversation

anshumanv
Copy link
Member

What kind of change does this PR introduce?
chore

Did you add tests for your changes?
NA

If relevant, did you update the documentation?
No

Summary

  • Removed unnecessary commit lint packages and adds a single conventional config

Does this PR introduce a breaking change?
No

Other information

@anshumanv anshumanv requested a review from a team as a code owner February 1, 2021 15:11
@codecov
Copy link

codecov bot commented Feb 1, 2021

Codecov Report

Merging #2394 (ca97679) into master (9d6dbda) will increase coverage by 0.47%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2394      +/-   ##
==========================================
+ Coverage   71.26%   71.74%   +0.47%     
==========================================
  Files          46       47       +1     
  Lines        2158     2173      +15     
  Branches      570      573       +3     
==========================================
+ Hits         1538     1559      +21     
+ Misses        620      614       -6     
Impacted Files Coverage Δ
...kages/generators/src/utils/modify-config-helper.ts 57.14% <0.00%> (-0.76%) ⬇️
packages/init/src/index.ts 88.88% <0.00%> (ø)
packages/webpack-cli/lib/bootstrap.js 100.00% <0.00%> (ø)
...ges/webpack-cli/lib/utils/dynamic-import-loader.js 83.33% <0.00%> (ø)
packages/webpack-cli/lib/webpack-cli.js 91.88% <0.00%> (+0.80%) ⬆️
packages/generators/src/utils/scaffold.ts 77.55% <0.00%> (+1.08%) ⬆️
packages/webpack-cli/lib/utils/index.js 84.00% <0.00%> (+1.39%) ⬆️
packages/webpack-cli/bin/cli.js 50.00% <0.00%> (+5.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d6dbda...ca97679. Read the comment docs.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@alexander-akait alexander-akait merged commit 805f9ff into webpack:master Feb 2, 2021
@alexander-akait
Copy link
Member

Thanks

@anshumanv anshumanv deleted the rm-cz branch February 2, 2021 10:57
snitin315 pushed a commit to snitin315/webpack-cli that referenced this pull request Feb 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants