feat: show possible values for option in help output #2819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| (flag) => option.long === `--${flag.name}`, | ||
| ); | ||
|
|
||
| if (flag && flag.configs[0].values) { |
There was a problem hiding this comment.
I think we can have more them, i.e. config[1]/config[2], I think better use map here and collect them
Codecov Report
@@ Coverage Diff @@
## master #2819 +/- ##
==========================================
+ Coverage 93.96% 94.05% +0.08%
==========================================
Files 32 32
Lines 1706 1715 +9
Branches 492 495 +3
==========================================
+ Hits 1603 1613 +10
+ Misses 103 102 -1
Continue to review full report at Codecov.
|
alexander-akait
approved these changes
Jul 7, 2021
|
Feel free to merge |
|
Need one more review. /cc @webpack/cli-team |
evenstensberg
approved these changes
Jul 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
feature
Did you add tests for your changes?
Yes updated snaps
If relevant, did you update the documentation?
No
Summary
show possible values for option in help output
Does this PR introduce a breaking change?
No
Other information
No