fix(webpack-cli): add an option for preventing interpret #3329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
shuta13
commented
Jul 6, 2022
|
@snitin315 ↑ Please check those. |
anshumanv
reviewed
Jul 14, 2022
rishabh3112
requested changes
Jul 17, 2022
webpack-bot
added
PR: review-outdated
and removed
PR: reviewed-changes-requested
labels
Co-authored-by: Anshuman Verma <anshu.av97@gmail.com>
|
Sorry for the late reply. I added the way to remove Please check and rerun the CI workflows. |
|
スタートしました〜 |
Codecov Report
@@ Coverage Diff @@
## master #3329 +/- ##
=======================================
Coverage 92.26% 92.27%
=======================================
Files 23 23
Lines 1733 1734 +1
Branches 519 520 +1
=======================================
+ Hits 1599 1600 +1
Misses 134 134
Continue to review full report at Codecov.
|
|
I forgot to update snapshots when testing with dev-server@3. : https://github.com/webpack/webpack-cli/runs/7462801069?check_suite_focus=true#step:9:96 I'll fix... |
|
It seems other tests are passing though which is good |
Thx. But, I'm worried about other contributors may be confused with the CI failing even though they don't make any changes. So, I update snapshots 🙏 : c1763f0 |
|
Thanks I've started CI, let's see if everything passes this time 🤞 |
snitin315
approved these changes
Jul 22, 2022
anshumanv
approved these changes
Jul 22, 2022
rishabh3112
approved these changes
Jul 22, 2022
alexander-akait
approved these changes
Jul 25, 2022
There was a problem hiding this comment.
@snitin315 After merge we will need to rebase the next branch, this can be a problem, maybe we will merge this directly in next?
|
@alexander-akait Yes, let's point this PR to the |
snitin315
added a commit
that referenced
this pull request
Jul 25, 2022
* fix(webpack-cli): add an option for preventing interpret * fix: define the option for built-in flags * docs: add descriptions of the option * refactor: rename `--config-registered` to `--disable-interpret` * fix: change conditional statement * refactor: standalone test * test: use `--disable-interpret` without transpilation * docs: fix the description Co-authored-by: Anshuman Verma <anshu.av97@gmail.com> * refactor: built-in options type Co-authored-by: Nitin Kumar <snitin315@gmail.com> * test: re-update snapshots * fix: add double quote Co-authored-by: Nitin Kumar <snitin315@gmail.com> * test: update snapshots for webpack4 * chore: remove `--require` from `test:coverage` * test: update snapshots Co-authored-by: Anshuman Verma <anshu.av97@gmail.com> Co-authored-by: Nitin Kumar <snitin315@gmail.com>
snitin315
added a commit
that referenced
this pull request
Sep 10, 2022
* fix(webpack-cli): add an option for preventing interpret * fix: define the option for built-in flags * docs: add descriptions of the option * refactor: rename `--config-registered` to `--disable-interpret` * fix: change conditional statement * refactor: standalone test * test: use `--disable-interpret` without transpilation * docs: fix the description Co-authored-by: Anshuman Verma <anshu.av97@gmail.com> * refactor: built-in options type Co-authored-by: Nitin Kumar <snitin315@gmail.com> * test: re-update snapshots * fix: add double quote Co-authored-by: Nitin Kumar <snitin315@gmail.com> * test: update snapshots for webpack4 * chore: remove `--require` from `test:coverage` * test: update snapshots Co-authored-by: Anshuman Verma <anshu.av97@gmail.com> Co-authored-by: Nitin Kumar <snitin315@gmail.com>
snitin315
added a commit
that referenced
this pull request
Sep 17, 2022
* fix(webpack-cli): add an option for preventing interpret * fix: define the option for built-in flags * docs: add descriptions of the option * refactor: rename `--config-registered` to `--disable-interpret` * fix: change conditional statement * refactor: standalone test * test: use `--disable-interpret` without transpilation * docs: fix the description Co-authored-by: Anshuman Verma <anshu.av97@gmail.com> * refactor: built-in options type Co-authored-by: Nitin Kumar <snitin315@gmail.com> * test: re-update snapshots * fix: add double quote Co-authored-by: Nitin Kumar <snitin315@gmail.com> * test: update snapshots for webpack4 * chore: remove `--require` from `test:coverage` * test: update snapshots Co-authored-by: Anshuman Verma <anshu.av97@gmail.com> Co-authored-by: Nitin Kumar <snitin315@gmail.com>
snitin315
added a commit
that referenced
this pull request
Sep 24, 2022
* fix(webpack-cli): add an option for preventing interpret * fix: define the option for built-in flags * docs: add descriptions of the option * refactor: rename `--config-registered` to `--disable-interpret` * fix: change conditional statement * refactor: standalone test * test: use `--disable-interpret` without transpilation * docs: fix the description Co-authored-by: Anshuman Verma <anshu.av97@gmail.com> * refactor: built-in options type Co-authored-by: Nitin Kumar <snitin315@gmail.com> * test: re-update snapshots * fix: add double quote Co-authored-by: Nitin Kumar <snitin315@gmail.com> * test: update snapshots for webpack4 * chore: remove `--require` from `test:coverage` * test: update snapshots Co-authored-by: Anshuman Verma <anshu.av97@gmail.com> Co-authored-by: Nitin Kumar <snitin315@gmail.com>
snitin315
added a commit
that referenced
this pull request
Sep 24, 2022
* fix(webpack-cli): add an option for preventing interpret * fix: define the option for built-in flags * docs: add descriptions of the option * refactor: rename `--config-registered` to `--disable-interpret` * fix: change conditional statement * refactor: standalone test * test: use `--disable-interpret` without transpilation * docs: fix the description Co-authored-by: Anshuman Verma <anshu.av97@gmail.com> * refactor: built-in options type Co-authored-by: Nitin Kumar <snitin315@gmail.com> * test: re-update snapshots * fix: add double quote Co-authored-by: Nitin Kumar <snitin315@gmail.com> * test: update snapshots for webpack4 * chore: remove `--require` from `test:coverage` * test: update snapshots Co-authored-by: Anshuman Verma <anshu.av97@gmail.com> Co-authored-by: Nitin Kumar <snitin315@gmail.com>
snitin315
added a commit
that referenced
this pull request
Oct 8, 2022
* fix(webpack-cli): add an option for preventing interpret * fix: define the option for built-in flags * docs: add descriptions of the option * refactor: rename `--config-registered` to `--disable-interpret` * fix: change conditional statement * refactor: standalone test * test: use `--disable-interpret` without transpilation * docs: fix the description Co-authored-by: Anshuman Verma <anshu.av97@gmail.com> * refactor: built-in options type Co-authored-by: Nitin Kumar <snitin315@gmail.com> * test: re-update snapshots * fix: add double quote Co-authored-by: Nitin Kumar <snitin315@gmail.com> * test: update snapshots for webpack4 * chore: remove `--require` from `test:coverage` * test: update snapshots Co-authored-by: Anshuman Verma <anshu.av97@gmail.com> Co-authored-by: Nitin Kumar <snitin315@gmail.com>
snitin315
added a commit
that referenced
this pull request
Oct 22, 2022
* fix(webpack-cli): add an option for preventing interpret * fix: define the option for built-in flags * docs: add descriptions of the option * refactor: rename `--config-registered` to `--disable-interpret` * fix: change conditional statement * refactor: standalone test * test: use `--disable-interpret` without transpilation * docs: fix the description Co-authored-by: Anshuman Verma <anshu.av97@gmail.com> * refactor: built-in options type Co-authored-by: Nitin Kumar <snitin315@gmail.com> * test: re-update snapshots * fix: add double quote Co-authored-by: Nitin Kumar <snitin315@gmail.com> * test: update snapshots for webpack4 * chore: remove `--require` from `test:coverage` * test: update snapshots Co-authored-by: Anshuman Verma <anshu.av97@gmail.com> Co-authored-by: Nitin Kumar <snitin315@gmail.com>
snitin315
added a commit
that referenced
this pull request
Nov 6, 2022
* fix(webpack-cli): add an option for preventing interpret * fix: define the option for built-in flags * docs: add descriptions of the option * refactor: rename `--config-registered` to `--disable-interpret` * fix: change conditional statement * refactor: standalone test * test: use `--disable-interpret` without transpilation * docs: fix the description Co-authored-by: Anshuman Verma <anshu.av97@gmail.com> * refactor: built-in options type Co-authored-by: Nitin Kumar <snitin315@gmail.com> * test: re-update snapshots * fix: add double quote Co-authored-by: Nitin Kumar <snitin315@gmail.com> * test: update snapshots for webpack4 * chore: remove `--require` from `test:coverage` * test: update snapshots Co-authored-by: Anshuman Verma <anshu.av97@gmail.com> Co-authored-by: Nitin Kumar <snitin315@gmail.com>
snitin315
added a commit
that referenced
this pull request
Nov 8, 2022
* fix(webpack-cli): add an option for preventing interpret * fix: define the option for built-in flags * docs: add descriptions of the option * refactor: rename `--config-registered` to `--disable-interpret` * fix: change conditional statement * refactor: standalone test * test: use `--disable-interpret` without transpilation * docs: fix the description Co-authored-by: Anshuman Verma <anshu.av97@gmail.com> * refactor: built-in options type Co-authored-by: Nitin Kumar <snitin315@gmail.com> * test: re-update snapshots * fix: add double quote Co-authored-by: Nitin Kumar <snitin315@gmail.com> * test: update snapshots for webpack4 * chore: remove `--require` from `test:coverage` * test: update snapshots Co-authored-by: Anshuman Verma <anshu.av97@gmail.com> Co-authored-by: Nitin Kumar <snitin315@gmail.com>
alexander-akait
pushed a commit
that referenced
this pull request
Nov 15, 2022
* fix(webpack-cli): add an option for preventing interpret * fix: define the option for built-in flags * docs: add descriptions of the option * refactor: rename `--config-registered` to `--disable-interpret` * fix: change conditional statement * refactor: standalone test * test: use `--disable-interpret` without transpilation * docs: fix the description Co-authored-by: Anshuman Verma <anshu.av97@gmail.com> * refactor: built-in options type Co-authored-by: Nitin Kumar <snitin315@gmail.com> * test: re-update snapshots * fix: add double quote Co-authored-by: Nitin Kumar <snitin315@gmail.com> * test: update snapshots for webpack4 * chore: remove `--require` from `test:coverage` * test: update snapshots Co-authored-by: Anshuman Verma <anshu.av97@gmail.com> Co-authored-by: Nitin Kumar <snitin315@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
A kind of bugfix.
Did you add tests for your changes?
Yes.
If relevant, did you update the documentation?
Users can check this option with the
webpack --help.Summary
Fixed #3195
Does this PR introduce a breaking change?
No.
Other information