Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] --silent #241

Merged
merged 1 commit into from
Jan 13, 2018
Merged

Conversation

jbottigliero
Copy link
Member

What kind of change does this PR introduce?
feature

Did you add tests for your changes?
Yes - the test is a duplicate of test/binCases/stats/multi-config, with some modifications to try and force more output.

If relevant, did you update the documentation?
webpack/webpack.js.org#1781

Summary
Related Issue: #22

This is possibly a naïve implementation, but seems to get the job done now that webpack-cli is it's own module.

Currently this change will not suppress output for the "non-compilation" commands. I can update this PR if it should, however most seem like they would not benefit from a --silent flag.

As far as the name for the actual flag, I can change that as well... @ev1stensberg previously mentioned -s/--save was taken at one point, but it looks open now?

Does this PR introduce a breaking change?
No

- Adds --silent option for suppressing output to stdout [webpack#22]
@webpack-bot
Copy link

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@evenstensberg
Copy link
Member

Thanks! Could you remove the quiet flag and its code while at it? Cc @bebraw

@jbottigliero
Copy link
Member Author

jbottigliero commented Jan 12, 2018

@ev1stensberg – I'm not so sure it was ever actually implemented. I'm not seeing anything in webpack@[next|master|webpack-1|webpack-2], or here... and based on the conversation in webpack/webpack#490 it seems like it could have just been abandoned before adding a ticket here (#22).

@evenstensberg
Copy link
Member

Remember adding the feature, maybe it has been discarded. I'll check and get back to you during the day

@evenstensberg evenstensberg merged commit b7bf719 into webpack:master Jan 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants