feat: Bundle analyzer #4141
Open
feat: Bundle analyzer #4141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To add a boilerplate
reverted to orignal state
undone uneccesssary changes
…ck-cli into bundle-analyzer merger
cli-flags.js
Outdated
| @@ -0,0 +1,159 @@ | |||
| "use strict"; | |||
|
|
|||
| module.exports = { | |||
There was a problem hiding this comment.
Is this needed? What problem does it solve?
There was a problem hiding this comment.
the file is made to privde the flags for the bundle analyzer plugin, had kept it in the root directory for now. Will move it to appropriate place.
There was a problem hiding this comment.
Please let me know if somethings wrong, or how to proceed further.
| simpleType: "boolean", | ||
| multiple: false, | ||
| }, | ||
| }; |
There was a problem hiding this comment.
Please send it to https://github.com/webpack-contrib/webpack-bundle-analyzer, this PR should be done in webpack-bundle-analyzer repo and here we just will read it from require("webpack-bundle-analyzer").cli.arguments
There was a problem hiding this comment.
@info-arnav could you do that?
|
@alexander-akait opened a PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
created a cli flags file, please review. if correct ill move forward to complete it.
@snitin315 @alexander-akait
#1838