-
-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove querystring from filenames when writing to disk #361
Conversation
Codecov Report
@@ Coverage Diff @@
## master #361 +/- ##
==========================================
+ Coverage 96.82% 96.83% +0.01%
==========================================
Files 7 7
Lines 252 253 +1
==========================================
+ Hits 244 245 +1
Misses 8 8
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #361 +/- ##
==========================================
+ Coverage 96.82% 96.83% +0.01%
==========================================
Files 7 7
Lines 252 253 +1
==========================================
+ Hits 244 245 +1
Misses 8 8
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job, we use same logic in webpack https://github.com/webpack/webpack/blob/master/lib/Compiler.js#L319, maybe we can increase perf using split
in webpack
What kind of change does this PR introduce?
This is a bug fix to bring file writing behavior closer to that of webpack and the WriteFilePlugin.
Did you add tests for your changes?
Yes
Summary
Webpack and the WriteFilePlugin cut off filenames at the first ?, so you can use filenames like
'[name].js?[contenthash]'
without writing hashes to your filesystem. This updates the dev middleware to do the same whenwriteToDisk
is enabled.Does this PR introduce a breaking change?
If you were using writeToDisk with a ? in
output.filename
then you won't end up with a ? in filenames on disk any more. If you pass a filter function towriteToDisk
then that function will also stop getting the querystring.Other information
Here's where querystrings get cut off in webpack and the writefileplugin:
https://github.com/webpack/webpack/blob/v4.28.4/lib/Compiler.js#L321
https://github.com/gajus/write-file-webpack-plugin/blob/v4.4.0/src/WriteFileWebpackPlugin.js#L174