You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm injecting an entrypoint to a iframe which has about:blank as source so that I have full control of injected DOM elements from the parent window. Problem is that therefore window.location.protocol has about: as value, which is obviously not https: as the parent window. I tried to force the socket url by using the public parameter in the options but it's missing support to force the protocol in the URL as well.
Actual Behavior
Protocol in public option is not supported (it's infered from the https property). Since I'm utilizing a nginx reverse proxy which does the https stuff, I don't want to enable the https options in dev-server.
For Bugs; How can we reproduce the behavior?
I'll create a PR in a few minutes which should show what's the problem and provide a fix for it..
The text was updated successfully, but these errors were encountered:
robertaistleitner
changed the title
public option doesn't allow explicitly set protocol
public option doesn't allow explicitly to set protocol
Sep 26, 2017
FWIW this isn't a bug, the behavior is by design so it really doesn't qualify as a bug. Rather, this is a request for a modification of the current behavior. I'll update the issue template to provide for that option in the future.
I'll create a PR in a few minutes which should show what's the problem and provide a fix for it..
Your PR didn't really explain what the problem here is, but we can infer the issue in code from the PR changeset. This issue is kind of all over the place. The bit about about:blank doesn't provide a whole lot of context but...
I tried to force the socket url by using the public parameter in the options but it's missing support to force the protocol in the URL as well.
...is where the meat of this issue lies. I'll header over to your PR (#1117) and continue the discussion. Moving forward, if you're planning on creating a PR immediately after your issue, you can skip the issue and just add all info to the PR.
Code
Expected Behavior
I'm injecting an entrypoint to a iframe which has
about:blank
as source so that I have full control of injected DOM elements from the parent window. Problem is that thereforewindow.location.protocol
hasabout:
as value, which is obviously nothttps:
as the parent window. I tried to force the socket url by using thepublic
parameter in the options but it's missing support to force the protocol in the URL as well.Actual Behavior
Protocol in
public
option is not supported (it's infered from thehttps
property). Since I'm utilizing a nginx reverse proxy which does the https stuff, I don't want to enable thehttps
options in dev-server.For Bugs; How can we reproduce the behavior?
I'll create a PR in a few minutes which should show what's the problem and provide a fix for it..
The text was updated successfully, but these errors were encountered: