fix(Server): don't use spdy on node >= v10.0.0

[addaleax]

• This is a bugfix
• This is a code refactor
• This is a test update
• This is a typo fix
• This is a metadata update

For Bugs and Features; did you add new tests?

This does add Node 10 to the test matrix. There do not seem to be any existing tests for https:// support, though, so I added one, even though it does not function as a regression test (one would actually have to explicitly use spdy/http2 for that).

Motivation / Use-Case

This fixes the bug reported at:

• Crash with "req.handle.writev is not a function" on Socket.Writable.uncork nodejs/node#21665
• Crash on node 10.6.0 and up #1449

Breaking Changes

This should not affect any user agents that detect protocol support themselves (like they should), in particular not browsers.

Additional Info

Another option that was considered was reverting the change that led to this in Node 10.

However, the spdy module is built in a very fragile manner, and unfortunately it seems unreasonable to expect that anything we can do inside of Node would be more than a stop-gap solution.

(See e.g. spdy-http2/node-spdy#333 for an attempt to reach out to the spdy maintainers about this problematic.)

[alexander-akait]

/cc @SpaceK33z

[codecov]

Codecov Report

Merging #1451 into master will increase coverage by 0.72%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1451      +/-   ##
==========================================
+ Coverage    73.3%   74.02%   +0.72%     
==========================================
  Files          10       10              
  Lines         663      666       +3     
==========================================
+ Hits          486      493       +7     
+ Misses        177      173       -4

Impacted Files	Coverage Δ
lib/Server.js	81.44% <100%> (+1.27%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4740224...cf3374b. Read the comment docs.

[addaleax]

Updated the test with an increased timeout because of the on-the-fly key generation.

(Edit: And updated again to appease the linter.)

[Jessidhia]

Unfortunately, just changing the module to http2 won't work because of expressjs/express#3388

Express doesn't seem to actually use node's request/response stuff but uses custom ones which are then setPrototypeOf to the node versions, and because of that it actually will not work correctly and crashes as soon as an h2 request happens.

[addaleax]

@Kovensky Without having looked into it deeper, from expressjs/express#3390 (comment) and below, it looks like there might be some movement in that area? :)

[addaleax]

Btw, are the recommendations for trying out pull requests in the CONTRIBUTING.md accurate? See e.g. nodejs/node#21665 (comment)

[leup]

Any news on this one ?

[alexander-akait]

/cc @Kovensky this PR don't fix problem? Can i look on original issue and/or minimum reproducible test repo?

[michael-ciniawsky]

I think this is definitely blocked by nodejs/node#21665 and expressjs/express#3388 atm

[Jessidhia]

@evilebottnawi this branch itself should reproduce it; the hard part is automated testing.

To reproduce it, just do an h2 connection to webpack-dev-server in --https mode.

---

@michael-ciniawsky "fixing" the node bug will just make the spdy module stop crashing but is not the real fix; either fixing the express bug or migrating away from express are.

[michael-ciniawsky]

@Kovensky Yep, I understand it's blocked on that :)

[addaleax]

I think this is definitely blocked by nodejs/node#21665 and expressjs/express#3388 atm

@michael-ciniawsky I’m not sure if I’m understanding you correctly, but this PR is not blocked on either of these issues. It fixes the first one, and the second one is just something to keep in mind for the future (fully migrating from SPDY to the built-in HTTP/2 module in Node would be dependent on it being solved).

What this PR may be blocked on is this issue, reported by somebody who tried this code out: nodejs/node#21665 (comment)

I don’t know enough about webpack-dev-server to figure out whether that issue is actually related, and if so, in what way. (And as @Kovensky said, automated testing is hard here & I’m not sure how to do it well.)

[addaleax]

I’ve rebased, and dropped the commit that adds Node 10 to the CI matrix since the .travis.yml has changed significantly (and I assume it would have been added anyway as part of that refactor if there was interest in it).