Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade http-proxy-middleware due Websocket Issue in 3.x branch #3004

Closed
Delagen opened this issue Feb 10, 2021 · 6 comments
Closed

Upgrade http-proxy-middleware due Websocket Issue in 3.x branch #3004

Delagen opened this issue Feb 10, 2021 · 6 comments

Comments

@Delagen
Copy link

Delagen commented Feb 10, 2021

Webpack: 3.11.1

// proxy.json
{
 "/ws/": {
    "target": "wss://some-server.ru",
    "changeOrigin": true,
    "logLevel": "debug",
    "ws": true
  }
}

Expected Behavior

No errors

Actual Behavior

Any WS connection to server during work cause
Error: read ECONNRESET
at TCP.onStreamRead (node:internal/stream_base_commons:213:20)
with crash

For Bugs; How can we reproduce the behavior?

For Features; What is the motivation and/or use-case for the feature?

Update version of middleware or make it less precise

@alexander-akait
Copy link
Member

alexander-akait commented Feb 10, 2021

Thank you for creating this issue. However, issues need to follow one of our templates so that we can clearly understand your particular circumstances.

Do not ignore how we can reproduce it, Error: read ECONNRESET means ws can't connect

@Delagen
Copy link
Author

Delagen commented Feb 10, 2021

Yes, but it crash entire dev-server

@alexander-akait
Copy link
Member

@Delagen Sorry using your information in the issue template I can't help you, I think nobody can help

@Delagen
Copy link
Author

Delagen commented Feb 10, 2021

Why you simply cannot upgrade package http-proxy-middleware in webpack-dev-server 3.x version?
chimurai/http-proxy-middleware#476

@alexander-akait
Copy link
Member

Because it will be breaking change, it updated for v4 (beta)

@alexander-akait
Copy link
Member

Fixed https://github.com/webpack/webpack-dev-server/blob/master/package.json#L48, we are working on new release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants